commit 88ab2404c2ae42ad8c30546b4565bb66b4cb1bf8
author Patrick Hiesel <hiesel@google.com> Fri Oct 01 13:07:36 2021 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Fri Oct 01 13:07:36 2021 +0000
tree a786992fe0fb6190adc0a1de147e485418aa40c6
parent 13729b11964283e42f9a181a56f22cc6640a8851
parent da1a34662fd7a17ffe913db67f2bade23f70e40b

Merge "Avoid opening the repository twice in ListProjects"

java/com/google/gerrit/server/restapi/project/ListProjects.java

diff --git a/java/com/google/gerrit/server/restapi/project/ListProjects.java b/java/com/google/gerrit/server/restapi/project/ListProjects.java
index c4ae33a..3ef9c8f 100644
--- a/java/com/google/gerrit/server/restapi/project/ListProjects.java
+++ b/java/com/google/gerrit/server/restapi/project/ListProjects.java
@@ -490,7 +490,7 @@
                 continue;
               }
 
-              List<Ref> refs = retrieveBranchRefs(e);
+              List<Ref> refs = retrieveBranchRefs(e, git);
               if (!hasValidRef(refs)) {
                 continue;
               }
@@ -578,7 +578,8 @@
     }
   }
 
-  private List<Ref> retrieveBranchRefs(ProjectState e) throws PermissionBackendException {
+  private List<Ref> retrieveBranchRefs(ProjectState e, Repository git)
+      throws PermissionBackendException {
     boolean canReadAllRefs = e.statePermitsRead();
     if (canReadAllRefs) {
       try {
@@ -588,7 +589,7 @@
       }
     }
 
-    return getBranchRefs(e.getNameKey(), canReadAllRefs);
+    return getBranchRefs(e.getNameKey(), canReadAllRefs, git);
   }
 
   private void addParentProjectInfo(
@@ -708,9 +709,10 @@
     stdout.flush();
   }
 
-  private List<Ref> getBranchRefs(Project.NameKey projectName, boolean canReadAllRefs) {
+  private List<Ref> getBranchRefs(
+      Project.NameKey projectName, boolean canReadAllRefs, Repository git) {
     Ref[] result = new Ref[showBranch.size()];
-    try (Repository git = repoManager.openRepository(projectName)) {
+    try {
       PermissionBackend.ForProject perm = permissionBackend.user(currentUser).project(projectName);
       for (int i = 0; i < showBranch.size(); i++) {
         Ref ref = git.findRef(showBranch.get(i));