commit 877400834009d5f53efbbd53caee2df21f299d2f
author Milutin Kristofic <milutin@google.com> Fri Feb 19 10:45:56 2021 +0100
committer Milutin Kristofic <milutin@google.com> Fri Feb 19 10:45:56 2021 +0100
tree 041aad6a694acbf4273195afc714c188b98bbc72
parent 1318c1bff8af56fc45851d1eef436ea33950dc75

Fix related-change-click metric for cherry-picks

Cherry picks don't have current change, so we want metrics
even if there isn't current change.

Change-Id: I5ab62a5c66f9a7fce51e49fcdf583dfc932a4358

polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.ts

diff --git a/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.ts b/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.ts
index b4b6d31..5705c4f 100644
--- a/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.ts
+++ b/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.ts
@@ -451,12 +451,14 @@
       ?.getElementsByClassName('arrowToCurrentChange')[0]
       ?.nextElementSibling?.nextElementSibling?.getElementsByTagName('a')[0];
 
-    if (!target || !currentChange) return;
+    if (!target) return;
     this.reportingService.reportInteraction('related-change-click', {
       sectionName,
       index: sectionLinks.indexOf(target) + 1,
       countChanges: sectionLinks.length,
-      currentChangeIndex: sectionLinks.indexOf(currentChange) + 1,
+      currentChangeIndex: !currentChange
+        ? undefined
+        : sectionLinks.indexOf(currentChange) + 1,
     });
   }
 }