commit 8714155a8b9d3eda6fef325fe9f89961d8b5688a
author David Ostrovsky <david@ostrovsky.org> Sat Feb 13 21:43:05 2021 +0100
committer Luca Milanesio <luca.milanesio@gmail.com> Wed Feb 17 16:14:00 2021 +0000
tree 4143df1e1db70f303b534714a303c1339172c829
parent 5ff1d4c240820180a789931c5a7024103defecaa

FileInfo: Fix ObjectEqualsForPrimitives pattern flagged by error prone

Running the recent error prone version is flagging error pattern:
ObjectEqualsForPrimitives:

FileInfo.java:37: error: [ObjectEqualsForPrimitives] Avoid unnecessary boxing by using plain == for primitive types.
          && Objects.equals(sizeDelta, fileInfo.sizeDelta)
                           ^
  (see https://errorprone.info/bugpattern/ObjectEqualsForPrimitives)
  Did you mean '&& (sizeDelta == fileInfo.sizeDelta)'?

Change-Id: I42d303242ed7a39a171d5182f61ba7276fb59f7f

java/com/google/gerrit/extensions/common/FileInfo.java

diff --git a/java/com/google/gerrit/extensions/common/FileInfo.java b/java/com/google/gerrit/extensions/common/FileInfo.java
index 32c5bd5..510c2ad 100644
--- a/java/com/google/gerrit/extensions/common/FileInfo.java
+++ b/java/com/google/gerrit/extensions/common/FileInfo.java
@@ -34,8 +34,8 @@
           && Objects.equals(oldPath, fileInfo.oldPath)
           && Objects.equals(linesInserted, fileInfo.linesInserted)
           && Objects.equals(linesDeleted, fileInfo.linesDeleted)
-          && Objects.equals(sizeDelta, fileInfo.sizeDelta)
-          && Objects.equals(size, fileInfo.size);
+          && sizeDelta == fileInfo.sizeDelta
+          && size == fileInfo.size;
     }
     return false;
   }