commit 8381312eb32db1ea6462a8062324074effcca2fd
author Edwin Kempin <ekempin@google.com> Thu Oct 13 15:12:50 2016 +0200
committer Edwin Kempin <ekempin@google.com> Thu Oct 13 15:12:50 2016 +0200
tree 9a79c09576ef765a09601133c884d70793af8ebc
parent 9b8e8895774b8393d686a9ecf4a599abdbff50ca

PutAssignee: Fail with 409 Conflict if validation of assignee fails

So far we returned 400 Bad Request, but this response code should be
used if the request is malformed or if mandatory fields in the input
are missing.

Change-Id: Ia864f300f29aedc53347f9f3660de905c946cd88
Signed-off-by: Edwin Kempin <ekempin@google.com>

gerrit-server/src/main/java/com/google/gerrit/server/change/SetAssigneeOp.java

diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/SetAssigneeOp.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/SetAssigneeOp.java
index ff33cde..7ef72ec 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/change/SetAssigneeOp.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/SetAssigneeOp.java
@@ -19,7 +19,7 @@
 import com.google.common.base.Optional;
 import com.google.gerrit.extensions.registration.DynamicSet;
 import com.google.gerrit.extensions.restapi.AuthException;
-import com.google.gerrit.extensions.restapi.BadRequestException;
+import com.google.gerrit.extensions.restapi.ResourceConflictException;
 import com.google.gerrit.extensions.restapi.RestApiException;
 import com.google.gerrit.extensions.restapi.UnprocessableEntityException;
 import com.google.gerrit.reviewdb.client.Account;
@@ -106,7 +106,7 @@
         validator.validateAssignee(change, newAssigneeUser.getAccount());
       }
     } catch (ValidationException e) {
-      throw new BadRequestException(e.getMessage());
+      throw new ResourceConflictException(e.getMessage());
     }
     // notedb
     update.setAssignee(newAssigneeUser.getAccountId());