Google Git
Sign in
gerrit / gerrit / 9b8e8895774b8393d686a9ecf4a599abdbff50ca
commit9b8e8895774b8393d686a9ecf4a599abdbff50ca[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Thu Oct 13 10:27:21 2016 +0200
committerEdwin Kempin <ekempin@google.com>Thu Oct 13 15:02:30 2016 +0200
treed0afc7cfdf5df4c65b46c16f38700c5e415635ad
parent50e25a2a41e21ff760b8e6e1313cb79ac801dba5 [diff]
PutAssignee: Fail with 400 Bad Request if in input no assignee is set

So far SetAssigneeOp accepted null as assignee if there was no old
assignee, but then trying to add the null assignee as reviewer failed
with a NullPointerException in PostReviewers#prepareApplication(...).

Deleting of assignees should be done via the DeleteAssignee REST
endpoint.

Move the permission check out of SetAssigneeOp, because we always do
this first before checking for bad requests (e.g. see SetHead).

Change-Id: Ia19e7a47d3925215deb13eb78e1814bb42cf5bae
Signed-off-by: Edwin Kempin <ekempin@google.com>
2 files changed
tree: d0afc7cfdf5df4c65b46c16f38700c5e415635ad
  1. .settings/
  2. bucklets/
  3. contrib/
  4. Documentation/
  5. gerrit-acceptance-framework/
  6. gerrit-acceptance-tests/
  7. gerrit-antlr/
  8. gerrit-cache-h2/
  9. gerrit-common/
  10. gerrit-elasticsearch/
  11. gerrit-extension-api/
  12. gerrit-gpg/
  13. gerrit-gwtdebug/
  14. gerrit-gwtexpui/
  15. gerrit-gwtui/
  16. gerrit-gwtui-common/
  17. gerrit-httpd/
  18. gerrit-index/
  19. gerrit-launcher/
  20. gerrit-lucene/
  21. gerrit-main/
  22. gerrit-oauth/
  23. gerrit-openid/
  24. gerrit-patch-commonsnet/
  25. gerrit-patch-jgit/
  26. gerrit-pgm/
  27. gerrit-plugin-api/
  28. gerrit-plugin-archetype/
  29. gerrit-plugin-gwt-archetype/
  30. gerrit-plugin-gwtui/
  31. gerrit-plugin-js-archetype/
  32. gerrit-prettify/
  33. gerrit-reviewdb/
  34. gerrit-server/
  35. gerrit-sshd/
  36. gerrit-util-cli/
  37. gerrit-util-http/
  38. gerrit-util-ssl/
  39. gerrit-war/
  40. lib/
  41. plugins/
  42. polygerrit-ui/
  43. ReleaseNotes/
  44. tools/
  45. website/
  46. .bazelrc
  47. .buckconfig
  48. .buckversion
  49. .editorconfig
  50. .gitignore
  51. .gitmodules
  52. .mailmap
  53. .pydevproject
  54. .watchmanconfig
  55. BUCK
  56. BUILD
  57. COPYING
  58. INSTALL
  59. README.md
  60. SUBMITTING_PATCHES
  61. VERSION
  62. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Buck and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && buck build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.