commit 7f2666d3f2ca46a3e115bb7d9afca77093d3d221
author Han-Wen Nienhuys <hanwen@google.com> Mon Jan 07 16:34:11 2019 +0100
committer Han-Wen Nienhuys <hanwen@google.com> Tue Jan 08 18:00:51 2019 +0100
tree 50bf4cdd13d866e7774fbd915d495837e0721e65
parent 978ba376f2a2ed6da8f3931ede9bd0c06d2778e8

CreateRefControl: add advice in the AuthException

We disallow new SHA1s in CreateBranch to avoid exposing objects to
users that they have no access to. Add an advice to mirror that.

Change-Id: I1811546782247c78829a1a2923d2422c86b29187

java/com/google/gerrit/server/project/CreateRefControl.java

diff --git a/java/com/google/gerrit/server/project/CreateRefControl.java b/java/com/google/gerrit/server/project/CreateRefControl.java
index f89e298..e841401 100644
--- a/java/com/google/gerrit/server/project/CreateRefControl.java
+++ b/java/com/google/gerrit/server/project/CreateRefControl.java
@@ -138,9 +138,15 @@
       return;
     }
 
-    throw new AuthException(
+    AuthException e =
+        new AuthException(
+            String.format(
+                "%s for creating new commit object not permitted",
+                RefPermission.UPDATE.describeForException()));
+    e.setAdvice(
         String.format(
-            "%s for creating new commit object not permitted",
+            "use a SHA1 visible to you, or get %s permission on the ref",
             RefPermission.UPDATE.describeForException()));
+    throw e;
   }
 }