| commit | 7974adfcbe92e903767e678c0629d2b46fdad026 | [log] [tgz] |
|---|---|---|
| author | Fabio Ponciroli <ponch78@gmail.com> | Wed Jun 07 12:19:09 2023 +0200 |
| committer | Fabio Ponciroli <ponch78@gmail.com> | Thu Jun 08 00:43:14 2023 +0200 |
| tree | 7a6612e27a863b2098252bcf427efc877ff2d223 | |
| parent | b4e0242e0540b97780a6e1f116e489e10f635fd5 [diff] |
Fix ExternalId differential loading when cache is inconsistent JGit may return a failure to update a repository, even if it actually succeeded. This can create an issue when loading externalIds, since we would retry to insert the same value into the cache twice, due to the retry performed by the client, leading the cache loader to consistently blow up. For example: Ext-Id1: * attempt to insert into All-Users: failed on JGit but not on disk [1] * the key Ext-Id1 is stored in cache Ext-Id1: * retry to insert into All-Users, because of JGit failure * try to add key Ext-Id1 entry BUT it already exists in cache => BOOM Make differential loading idempotent to avoid failures due to retry to insert the same entry again. Make "buildAllExternalIds" package-private for testing visibility. [1]: https://bugs.eclipse.org/bugs/show_bug.cgi?id=582044 Bug: Issue 16384 Release-Notes: Fix ExternalId differential loading when cache is inconsistent Change-Id: Iba6d538451994045b4455829d995dadd38866332
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.