tree 7a6612e27a863b2098252bcf427efc877ff2d223
parent b4e0242e0540b97780a6e1f116e489e10f635fd5
author Fabio Ponciroli <ponch78@gmail.com> 1686133149 +0200
committer Fabio Ponciroli <ponch78@gmail.com> 1686177794 +0200

Fix ExternalId differential loading when cache is inconsistent

JGit may return a failure to update a repository, even if it actually
succeeded.

This can create an issue when loading externalIds, since
we would retry to insert the same value into the cache twice,
due to the retry performed by the client, leading the cache
loader to consistently blow up.

For example:
Ext-Id1:
 * attempt to insert into All-Users: failed on JGit but not on disk [1]
 * the key Ext-Id1 is stored in cache
Ext-Id1:
 * retry to insert into All-Users, because of JGit failure
 * try to add key Ext-Id1 entry BUT it already exists in cache => BOOM

Make differential loading idempotent to avoid failures due to retry to
insert the same entry again.

Make "buildAllExternalIds" package-private for testing visibility.

[1]: https://bugs.eclipse.org/bugs/show_bug.cgi?id=582044

Bug: Issue 16384
Release-Notes: Fix ExternalId differential loading when cache is inconsistent
Change-Id: Iba6d538451994045b4455829d995dadd38866332