CacheBasedWebSession: Remove misplaced RequestScoped annotation
Scope annotations should not be applied on abstract classes or
interfaces as scope annotations are not inherited and hence
having them on abstract classes / interfaces has no effect.
Scope annotations must be applied only where the binding is created,
for example on a @Provides method, or on the class definition of a
concrete type.
H2CacheBasedWebSession which is the only implementation (outside of
tests) is already annotated with @RequestScoped, so @RequestScoped on
the abstract CacheBasedWebSession class can simply be dropped.
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I927db15b1130508fd30170bd692d8b6c062f11c3
diff --git a/java/com/google/gerrit/httpd/CacheBasedWebSession.java b/java/com/google/gerrit/httpd/CacheBasedWebSession.java
index 1605397..92e16ce 100644
--- a/java/com/google/gerrit/httpd/CacheBasedWebSession.java
+++ b/java/com/google/gerrit/httpd/CacheBasedWebSession.java
@@ -32,14 +32,12 @@
import com.google.gerrit.server.account.externalids.ExternalId;
import com.google.gerrit.server.config.AuthConfig;
import com.google.inject.Provider;
-import com.google.inject.servlet.RequestScoped;
import java.util.EnumSet;
import javax.servlet.http.Cookie;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.eclipse.jgit.http.server.GitSmartHttpTools;
-@RequestScoped
public abstract class CacheBasedWebSession extends WebSession {
@VisibleForTesting public static final String ACCOUNT_COOKIE = "GerritAccount";
protected static final long MAX_AGE_MINUTES = HOURS.toMinutes(12);
