| commit | 7363c331c5ea11d2cf33bcfbb7603e307fcf70cd | [log] [tgz] |
|---|---|---|
| author | Gal Paikin <paiking@google.com> | Tue Feb 16 15:35:19 2021 +0100 |
| committer | Gal Paikin <paiking@google.com> | Thu Feb 18 11:14:30 2021 +0100 |
| tree | e7156b6bc845d5d305199ae9827c729eb69bc883 | |
| parent | 5f39431c027cbe909c44fdd6a26d42ddabc66e4c [diff] |
Filter out merged changes when submitting a topic There is a bug that occurs when topic submission fails, which causes a stale change index. As a result, we throw an exception that some of the open changes found in the index are actually merged, hence we fail the entire submission. We anyway reload the changes from NoteDb during submit, so after we reload it's a good idea to filter out merged changes. If the current change is merged though, we would fail before reaching this code, which makes sense. This bug still occurs in SubmittedTogether, since there we don't reload all the changes from the storage. This is significantly less important, though. This bug *doesn't* occur whether deciding whether to show the "submit" button, since we just trust that the changes are not stale, and show the submit button in such a case (which works fine). The submit button won't show on merged changes, since that one specific change we do have in storage. Change-Id: I4a8d219c5d80f56432b91713487e33b7628a7b1c
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.