tree e7156b6bc845d5d305199ae9827c729eb69bc883
parent 5f39431c027cbe909c44fdd6a26d42ddabc66e4c
author Gal Paikin <paiking@google.com> 1613486119 +0100
committer Gal Paikin <paiking@google.com> 1613643270 +0100

Filter out merged changes when submitting a topic

There is a bug that occurs when topic submission fails, which causes a
stale change index. As a result, we throw an exception that some of the
open changes found in the index are actually merged, hence we fail the
entire submission.

We anyway reload the changes from NoteDb during submit, so after we
reload it's a good idea to filter out merged changes. If the
current change is merged though, we would fail before reaching this
code, which makes sense.

This bug still occurs in SubmittedTogether, since there we don't reload
all the changes from the storage. This is significantly less important,
though.

This bug *doesn't* occur whether deciding whether to show the "submit"
button, since we just trust that the changes are not stale, and show
the submit button in such a case (which works fine). The submit button
won't show on merged changes, since that one specific change we do have
in storage.

Change-Id: I4a8d219c5d80f56432b91713487e33b7628a7b1c