| commit | bffb02d3e36bd9e621ef7c50e9e1cf00c92f0d2d | [log] [tgz] |
|---|---|---|
| author | Youssef Elghareeb <ghareeb@google.com> | Tue Nov 30 12:35:40 2021 +0100 |
| committer | Youssef Elghareeb <ghareeb@google.com> | Wed Dec 01 17:16:24 2021 +0100 |
| tree | daaf63faf72917a6c71980ddec4392371fb2f006 | |
| parent | a4034715974fdcf2be40cf2145452d1229686d80 [diff] |
Copy approvals to the latest PS by matching labels with submit records Background: we store submit records in NoteDb when the change is merged. Submit records optionally contain a list of labels and the account ID that applied the vote, but they do not contain the vote value. Problem we are solving: approvals from prior patchsets are no longer copied on demand but approvals are solely read from NoteDb. For old changes copied approvals are not stored in NoteDb because they were not backfilled. For merged changes, this means that approvals for labels that were required for submit and that were satisfied by copied votes are no longer shown, so we need to backfill them. In this change, we update reading back approvals from NoteDb for closed changes: If we find a submit record with an approved label from some user and we don't find a corresponding approval for it at the latest patchset, we search for the most recent non-latest patchset that contains an approval for this label from the user and copy it to the latest patchset. Change-Id: I58ea31a5fec033f28cdb9e51f96ea47676816d76
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.