Fix file comments
This presumably broke in a recent refactoring: File comments do not have
the line-num attribute set, thus it returns null or empty string, which
Number converts to 0. That 0 was then used to query for the data-value
attribute on the line number elements, return null, crashing with a
"cannot get property parentElement of null" error.
The fix is to check if line-num is set, and if not query for "FILE".
Change-Id: I3335c5c8cba101ebe353954bb11ddceaad1d86ce
diff --git a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.js b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.js
index 76a62b8..1c6c8cf 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.js
+++ b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.js
@@ -600,10 +600,10 @@
// removed by no longer slotting them in, so I decided to not handle
// this situation until it occurs.
for (const threadEl of addedThreadEls) {
- const lineNum = Number(threadEl.getAttribute('line-num'));
+ const lineNumString = threadEl.getAttribute('line-num') || 'FILE';
const commentSide = threadEl.getAttribute('comment-side');
const lineEl = this.$.diffBuilder.getLineElByNumber(
- lineNum, commentSide);
+ lineNumString, commentSide);
const contentText = this.$.diffBuilder.getContentByLineEl(lineEl);
const contentEl = contentText.parentElement;
const threadGroupEl = this._getOrCreateThreadGroup(contentEl);
