commit | 6f15c45498e0e4c137f2d6f7002634cb9f5c3ce4 | [log] [tgz] |
---|---|---|
author | Ole Rehmsen <oler@google.com> | Tue Nov 13 13:26:16 2018 +0100 |
committer | Ole Rehmsen <oler@google.com> | Tue Nov 13 13:26:16 2018 +0100 |
tree | 34678a5ac6cb47a96acd6e2bd1c38891115df79f | |
parent | 8a460d17a067f6a7250ae23180a1965c99883547 [diff] |
Fix file comments This presumably broke in a recent refactoring: File comments do not have the line-num attribute set, thus it returns null or empty string, which Number converts to 0. That 0 was then used to query for the data-value attribute on the line number elements, return null, crashing with a "cannot get property parentElement of null" error. The fix is to check if line-num is set, and if not query for "FILE". Change-Id: I3335c5c8cba101ebe353954bb11ddceaad1d86ce
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.