commit | 6eaa89988af4b3b34c9c3391f382ca78c5536236 | [log] [tgz] |
---|---|---|
author | Youssef Elghareeb <ghareeb@google.com> | Wed Jun 23 14:20:50 2021 +0200 |
committer | Youssef Elghareeb <ghareeb@google.com> | Wed Jun 23 14:27:47 2021 +0200 |
tree | baa709616a3e1fe7b59865d58d704bb98161797f | |
parent | 3546b572e569cc0175debdbb2ba577d959e33c2c [diff] |
Refactor keys transformation in comment context This change is a no/op. We perform two transformations on comment context keys before requesting context from the cache: 1) We adjust max padding: If padding exceeds a threshold we set padding to the max. 2) We hash the file path (cache keys should not contain plain file paths). Chaining both transormations in a single statement and keeping a map from the input keys to the cache key for better readability. This change is already covered by tests in CommentContextIT. Motivation: we saw few exceeptions in logs that suggested putting a null value in the result map, i.e. allContext.get(key) returned null. This could have been due to a hidden bug while doing the two transformations. This should never happen because the cache should return a result for every input key by contract, or throw an exception otherwise. Change-Id: I6803b31b20392f5eff4c54556fde77dfeb094384
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.