tree baa709616a3e1fe7b59865d58d704bb98161797f
parent 3546b572e569cc0175debdbb2ba577d959e33c2c
author Youssef Elghareeb <ghareeb@google.com> 1624450850 +0200
committer Youssef Elghareeb <ghareeb@google.com> 1624451267 +0200

Refactor keys transformation in comment context

This change is a no/op. We perform two transformations on comment
context keys before requesting context from the cache: 1) We adjust max
padding: If padding exceeds a threshold we set padding to the max.  2)
We hash the file path (cache keys should not contain plain file paths).

Chaining both transormations in a single statement and keeping a map
from the input keys to the cache key for better readability.

This change is already covered by tests in CommentContextIT.

Motivation: we saw few exceeptions in logs that suggested putting a null
value in the result map, i.e. allContext.get(key) returned null. This
could have been due to a hidden bug while doing the two transformations.
This should never happen because the cache should return a result for
every input key by contract, or throw an exception otherwise.

Change-Id: I6803b31b20392f5eff4c54556fde77dfeb094384