| commit | 6e8748f09b8d6dd272746bec19d3a1f40f0b2a76 | [log] [tgz] |
|---|---|---|
| author | Ben Rohlfs <brohlfs@google.com> | Wed Aug 07 10:16:59 2019 +0000 |
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | Wed Aug 07 10:16:59 2019 +0000 |
| tree | 99bd4dce6c53a96c08b19f4b127a2911722bf93f | |
| parent | a82ab783baa430ad925a2934bbfa5f6310652ea3 [diff] | |
| parent | 388bc904c08971961ec1bf831280be97de2e5abf [diff] |
Merge "Login is false when network fails"
diff --git a/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js b/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js index c3fc3a2..322cf5a 100644 --- a/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js +++ b/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface.js
@@ -1095,6 +1095,8 @@ getLoggedIn() { return this.getAccount().then(account => { return account != null; + }).catch(() => { + return false; }); },
diff --git a/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface_test.html b/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface_test.html index 4c35151..748cb83 100644 --- a/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface_test.html +++ b/polygerrit-ui/app/elements/shared/gr-rest-api-interface/gr-rest-api-interface_test.html
@@ -494,6 +494,15 @@ }); }); + test('getLoggedIn returns false when network/auth failure', done => { + window.fetch.returns( + Promise.reject(new Error('Failed to fetch'))); + element.getLoggedIn().then(isLoggedIn => { + assert.isFalse(isLoggedIn); + done(); + }); + }); + test('checkCredentials', done => { const responses = [ {