Google Git
Sign in
gerrit / gerrit / 6cd66007bed321866ca233fa2142099b97e4bd6d
commit6cd66007bed321866ca233fa2142099b97e4bd6d[log] [tgz]
authorYoussef Elghareeb <ghareeb@google.com>Mon Oct 11 14:57:17 2021 +0200
committerYoussef Elghareeb <ghareeb@google.com>Mon Oct 11 15:25:15 2021 +0200
tree6fe2ad442d4e11adc2eb7ca3ab84393d0b3eae38
parent6ae2ddb61737e037190a6dcb04faef5e84189df3 [diff]
Do not store legacy submit records as submit requirements upon merge

We have a submit operation (StoreSubmitRequirementsOp) that stores
submit requirements in NoteDb when the change is merged. This relies on
SubmitRequirementsEvaluator to compute submit requirements that are then
stored. If the "enable_legacy_submit_requirements" experiment feature is
enabled, SubmitRequirementsEvaluator also retrieves legacy submit
records and converts them to submit requirements. This was necessary so
that we can surface submit requirements to the users based on legacy
submit records.

We don't want these legacy "converted" submit records to
be stored as submit requirements in NoteDb when the change is being
merged, hence we are doing it in this change. When surfing submit
requirements for closed changes to users we will:
1) Retrieve stored submit requirements from NoteDb.
2) Retrieve stored legacy submit records from NoteDb and convert them to
submit requirements. We will implement this in a follow up change.

Change-Id: If4fa6aa4a07cfd1bedc89cc6834270fb590a919f
5 files changed
tree: 6fe2ad442d4e11adc2eb7ca3ab84393d0b3eae38
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. WORKSPACE
  41. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.