tree 6fe2ad442d4e11adc2eb7ca3ab84393d0b3eae38
parent 6ae2ddb61737e037190a6dcb04faef5e84189df3
author Youssef Elghareeb <ghareeb@google.com> 1633957037 +0200
committer Youssef Elghareeb <ghareeb@google.com> 1633958715 +0200

Do not store legacy submit records as submit requirements upon merge

We have a submit operation (StoreSubmitRequirementsOp) that stores
submit requirements in NoteDb when the change is merged. This relies on
SubmitRequirementsEvaluator to compute submit requirements that are then
stored. If the "enable_legacy_submit_requirements" experiment feature is
enabled, SubmitRequirementsEvaluator also retrieves legacy submit
records and converts them to submit requirements. This was necessary so
that we can surface submit requirements to the users based on legacy
submit records.

We don't want these legacy "converted" submit records to
be stored as submit requirements in NoteDb when the change is being
merged, hence we are doing it in this change. When surfing submit
requirements for closed changes to users we will:
1) Retrieve stored submit requirements from NoteDb.
2) Retrieve stored legacy submit records from NoteDb and convert them to
submit requirements. We will implement this in a follow up change.

Change-Id: If4fa6aa4a07cfd1bedc89cc6834270fb590a919f