commit 658653c96c60adc7b44c5be5d48c7ca1dacf254e
author Milutin Kristofic <milutin@google.com> Wed Nov 25 09:40:39 2020 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Wed Nov 25 09:40:39 2020 +0000
tree baf8b29e23d558eba1e02963863b7251d4457208
parent 0ae2a54c12d7532571875622f25224bee91d49f4
parent aa761ea1b2dbf42a0f09d6d506d78daeebfc19fc

Merge "Fix A11y regression"

polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-side-by-side.ts

diff --git a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-side-by-side.ts b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-side-by-side.ts
index 1ae302a..ecedb28 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-side-by-side.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-side-by-side.ts
@@ -105,6 +105,8 @@
     row.classList.add('diff-row', 'side-by-side');
     row.setAttribute('left-type', leftLine.type);
     row.setAttribute('right-type', rightLine.type);
+    // TabIndex makes screen reader read a row when navigating with j/k
+    row.tabIndex = -1;
 
     row.appendChild(this._createBlameCell(leftLine.beforeNumber));
 

polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-unified.ts

diff --git a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-unified.ts b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-unified.ts
index 04ac472..2011a59 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-unified.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-unified.ts
@@ -104,6 +104,8 @@
   _createRow(line: GrDiffLine) {
     const row = this._createElement('tr', line.type);
     row.classList.add('diff-row', 'unified');
+    // TabIndex makes screen reader read a row when navigating with j/k
+    row.tabIndex = -1;
     row.appendChild(this._createBlameCell(line.beforeNumber));
     let lineNumberEl = this._createLineEl(
       line,