commit 649081144bed0469cc8dc12fb1b52c8bf3f9f32f
author Edwin Kempin <ekempin@google.com> Fri Feb 26 08:35:51 2021 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Fri Feb 26 08:35:51 2021 +0000
tree 05bb71d4a19455b8c521796ebc029704d5816e9c
parent b6198a3b0999c8e3724b90c083fdea4749e451db
parent 6fdf2aaa9b329c5111b06540fdc2e57352c8f6cf

Merge "Fix tiny performance nit in ApprovalInferance"

java/com/google/gerrit/server/ApprovalInference.java

diff --git a/java/com/google/gerrit/server/ApprovalInference.java b/java/com/google/gerrit/server/ApprovalInference.java
index 40bf249..d77427a 100644
--- a/java/com/google/gerrit/server/ApprovalInference.java
+++ b/java/com/google/gerrit/server/ApprovalInference.java
@@ -25,6 +25,7 @@
 import com.google.gerrit.common.Nullable;
 import com.google.gerrit.entities.Account;
 import com.google.gerrit.entities.LabelType;
+import com.google.gerrit.entities.LabelTypes;
 import com.google.gerrit.entities.Patch.ChangeType;
 import com.google.gerrit.entities.PatchSet;
 import com.google.gerrit.entities.PatchSetApproval;
@@ -368,11 +369,12 @@
         "change kind for patch set %d of change %d against prior patch set %s is %s",
         ps.id().get(), ps.id().changeId().get(), priorPatchSet.getValue().id().changeId(), kind);
     PatchList patchList = null;
+    LabelTypes labelTypes = project.getLabelTypes();
     for (PatchSetApproval psa : priorApprovals) {
       if (resultByUser.contains(psa.label(), psa.accountId())) {
         continue;
       }
-      LabelType type = project.getLabelTypes().byLabel(psa.labelId());
+      LabelType type = labelTypes.byLabel(psa.labelId());
       // Only compute patchList if there is a relevant label, since this is expensive.
       if (patchList == null && type != null && type.isCopyAllScoresIfListOfFilesDidNotChange()) {
         patchList = getPatchList(project, ps, priorPatchSet);