Move [Abandon] action back up to the top-level Abandon actions are moved out of the overflow actions menu to the top level on account of its frequent use in common workflows. Bug: Issue 5436 Change-Id: I77f1e15db12412ec4d2a3476cb547744d7fe403a
diff --git a/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.html b/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.html index 982e400..9f31550 100644 --- a/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.html +++ b/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.html
@@ -81,7 +81,6 @@ down-arrow vertical-offset="32" horizontal-align="right" - on-tap-item-abandon="_handleAbandonTap" on-tap-item-cherrypick="_handleCherrypickTap" on-tap-item-delete="_handleDeleteTap" hidden$="[[_shouldHideActions(_menuActions.*, _loading)]]"
diff --git a/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js b/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js index 69f4f57..148b724 100644 --- a/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js +++ b/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js
@@ -92,7 +92,6 @@ * set of action buttons. */ var MENU_ACTION_KEYS = [ - 'abandon', 'cherrypick', '/', // '/' is the key for the delete action. ]; @@ -452,6 +451,8 @@ this._handleRevisionAction(key); } else if (key === ChangeActions.REVERT) { this.showRevertDialog(); + } else if (key === ChangeActions.ABANDON) { + this._showActionDialog(this.$.confirmAbandonDialog); } else if (key === QUICK_APPROVE_ACTION.key) { var action = this._allActionValues.find(function(o) { return o.key === key;