Do not stop default behavior of mouse click events. This was stopping default behavior of middle-click paste on X11 systems. Change-Id: I44adc2032be92507a1247f27ec38ea969f96bddf Release-Notes: skip Google-Bug-Id: b/339892865
diff --git a/polygerrit-ui/app/embed/gr-textarea.ts b/polygerrit-ui/app/embed/gr-textarea.ts index 9b88e9c..05bef49 100644 --- a/polygerrit-ui/app/embed/gr-textarea.ts +++ b/polygerrit-ui/app/embed/gr-textarea.ts
@@ -318,7 +318,7 @@ range.detach(); - this.onCursorPositionChange(null); + this.onCursorPositionChange(); } public setCursorPosition(position: number) { @@ -446,7 +446,7 @@ range.detach(); - this.onCursorPositionChange(null); + this.onCursorPositionChange(); } private async onInput(event: Event) { @@ -459,15 +459,15 @@ this.fire('input', {value: this.value}); } - private onFocus(event: Event) { + private onFocus() { this.focused = true; - this.onCursorPositionChange(event); + this.onCursorPositionChange(); } - private onBlur(event: Event) { + private onBlur() { this.focused = false; this.removeHintSpanIfShown(); - this.onCursorPositionChange(event); + this.onCursorPositionChange(); } private async handleKeyDown(event: KeyboardEvent) { @@ -491,12 +491,12 @@ await this.toggleHintVisibilityIfAny(); } - private handleKeyUp(event: KeyboardEvent) { - this.onCursorPositionChange(event); + private handleKeyUp() { + this.onCursorPositionChange(); } - private async handleMouseUp(event: MouseEvent) { - this.onCursorPositionChange(event); + private async handleMouseUp() { + this.onCursorPositionChange(); await this.toggleHintVisibilityIfAny(); } @@ -596,10 +596,7 @@ return this.shadowRoot?.querySelector('.' + AUTOCOMPLETE_HINT_CLASS); } - private onCursorPositionChange(event: Event | null) { - event?.preventDefault(); - event?.stopImmediatePropagation(); - + private onCursorPositionChange() { this.fire('cursorPositionChange', {position: this.getCursorPosition()}); }