Fix template problems with gr-account-entry Change-Id: I64bb5c13ffc7943f5cdbd51a42c6b7f0dc76816d
diff --git a/polygerrit-ui/app/BUILD b/polygerrit-ui/app/BUILD index 1591738..7d6386d 100644 --- a/polygerrit-ui/app/BUILD +++ b/polygerrit-ui/app/BUILD
@@ -121,7 +121,6 @@ "elements/gr-app-element_html.ts", "elements/settings/gr-settings-view/gr-settings-view_html.ts", "elements/settings/gr-watched-projects-editor/gr-watched-projects-editor_html.ts", - "elements/shared/gr-account-entry/gr-account-entry_html.ts", "elements/shared/gr-account-label/gr-account-label_html.ts", "elements/shared/gr-account-list/gr-account-list_html.ts", "elements/shared/gr-autocomplete/gr-autocomplete_html.ts",
diff --git a/polygerrit-ui/app/elements/shared/gr-account-entry/gr-account-entry.ts b/polygerrit-ui/app/elements/shared/gr-account-entry/gr-account-entry.ts index 944054e..c250428 100644 --- a/polygerrit-ui/app/elements/shared/gr-account-entry/gr-account-entry.ts +++ b/polygerrit-ui/app/elements/shared/gr-account-entry/gr-account-entry.ts
@@ -54,13 +54,13 @@ */ @property({type: Boolean}) - allowAnyInput?: boolean; + allowAnyInput = false; @property({type: Boolean}) - borderless?: boolean; + borderless = false; @property({type: String}) - placeholder?: string; + placeholder = ''; @property({type: Number}) suggestFrom = 0; @@ -69,7 +69,7 @@ querySuggestions: AutocompleteQuery = () => Promise.resolve([]); @property({type: String, observer: '_inputTextChanged'}) - _inputText?: string; + _inputText = ''; get focusStart() { return this.$.input.focusStart;
diff --git a/polygerrit-ui/app/types/events.ts b/polygerrit-ui/app/types/events.ts index 6e37697..5145527 100644 --- a/polygerrit-ui/app/types/events.ts +++ b/polygerrit-ui/app/types/events.ts
@@ -26,6 +26,7 @@ CHANGE = 'change', CHANGED = 'changed', CHANGE_MESSAGE_DELETED = 'change-message-deleted', + COMMIT = 'commit', DIALOG_CHANGE = 'dialog-change', DROP = 'drop', EDITABLE_CONTENT_SAVE = 'editable-content-save', @@ -58,6 +59,8 @@ /* prettier-ignore */ 'changed': ChangedEvent; 'change-message-deleted': ChangeMessageDeletedEvent; + /* prettier-ignore */ + 'commit': CommitEvent; 'dialog-change': DialogChangeEvent; /* prettier-ignore */ 'drop': DropEvent; @@ -109,6 +112,8 @@ } export type ChangeMessageDeletedEvent = CustomEvent<ChangeMessageDeletedEventDetail>; +export type CommitEvent = CustomEvent; + // TODO(milutin) - remove once new gr-dialog will do it out of the box // This informs gr-app-element to remove footer, header from a11y tree export interface DialogChangeEventDetail {