commit 5f520daaa8afa3ffe7e719a1b02a226907197d96
author Ben Rohlfs <brohlfs@google.com> Wed Mar 10 14:58:43 2021 +0100
committer Ben Rohlfs <brohlfs@google.com> Wed Mar 10 15:06:49 2021 +0100
tree 05bb6da4304476baa16304efa646f13c0ecb5cd9
parent 5d30f4eb14f83242479863c39d884d17b89114e6

Replace at-/de-tached with dis-connectedCallback

attached() and detached() are Polymer 1 legacy.

Change-Id: Ic86d07bfb95ec316880db261a913004f5a6e5a22

polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.ts

diff --git a/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.ts b/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.ts
index e6f08b01..d40a8a6 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.ts
@@ -307,17 +307,17 @@
   }
 
   /** @override */
-  attached() {
-    super.attached();
+  connectedCallback() {
+    super.connectedCallback();
     this._getLoggedIn().then(loggedIn => {
       this._loggedIn = loggedIn;
     });
   }
 
   /** @override */
-  detached() {
-    super.detached();
+  disconnectedCallback() {
     this.clear();
+    super.disconnectedCallback();
   }
 
   initLayers() {

polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host_test.js

diff --git a/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host_test.js b/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host_test.js
index 3d6383b..267ca5f 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host_test.js
+++ b/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host_test.js
@@ -970,7 +970,7 @@
   suite('create-comment', () => {
     setup(async () => {
       loggedIn = true;
-      element.attached();
+      element.connectedCallback();
       await flush();
     });