Replace at-/de-tached with dis-connectedCallback attached() and detached() are Polymer 1 legacy. Change-Id: Ic86d07bfb95ec316880db261a913004f5a6e5a22
diff --git a/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.ts b/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.ts index 221ab54..f3a7fd3 100644 --- a/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.ts +++ b/polygerrit-ui/app/elements/admin/gr-admin-group-list/gr-admin-group-list.ts
@@ -97,8 +97,8 @@ private readonly restApiService = appContext.restApiService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this._getCreateGroupCapability(); fireTitleChange(this, 'Groups'); this._maybeOpenCreateOverlay(this.params);
diff --git a/polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view.ts b/polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view.ts index 31f87ce..5647b25 100644 --- a/polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view.ts +++ b/polygerrit-ui/app/elements/admin/gr-admin-view/gr-admin-view.ts
@@ -175,8 +175,8 @@ private readonly jsAPI = appContext.jsApiService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this.reload(); }
diff --git a/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.ts b/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.ts index a2b17ead5..102768c 100644 --- a/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.ts +++ b/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.ts
@@ -95,8 +95,8 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); if (!this.repoName) { return Promise.resolve(); }
diff --git a/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.ts b/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.ts index 6338988..959bfa3 100644 --- a/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.ts +++ b/polygerrit-ui/app/elements/admin/gr-group-audit-log/gr-group-audit-log.ts
@@ -57,8 +57,8 @@ private readonly restApiService = appContext.restApiService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); fireTitleChange(this, 'Audit Log'); }
diff --git a/polygerrit-ui/app/elements/admin/gr-group-members/gr-group-members.ts b/polygerrit-ui/app/elements/admin/gr-group-members/gr-group-members.ts index 79eee7d..f7a2c8b 100644 --- a/polygerrit-ui/app/elements/admin/gr-group-members/gr-group-members.ts +++ b/polygerrit-ui/app/elements/admin/gr-group-members/gr-group-members.ts
@@ -123,8 +123,8 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this._loadGroupDetails(); fireTitleChange(this, 'Members');
diff --git a/polygerrit-ui/app/elements/admin/gr-group/gr-group.ts b/polygerrit-ui/app/elements/admin/gr-group/gr-group.ts index 8e49479..1ef80a9 100644 --- a/polygerrit-ui/app/elements/admin/gr-group/gr-group.ts +++ b/polygerrit-ui/app/elements/admin/gr-group/gr-group.ts
@@ -131,8 +131,8 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this._loadGroup(); }
diff --git a/polygerrit-ui/app/elements/admin/gr-plugin-list/gr-plugin-list.ts b/polygerrit-ui/app/elements/admin/gr-plugin-list/gr-plugin-list.ts index a6a1a42..2a07d2f 100644 --- a/polygerrit-ui/app/elements/admin/gr-plugin-list/gr-plugin-list.ts +++ b/polygerrit-ui/app/elements/admin/gr-plugin-list/gr-plugin-list.ts
@@ -79,8 +79,8 @@ private readonly restApiService = appContext.restApiService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); fireTitleChange(this, 'Plugins'); }
diff --git a/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.ts b/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.ts index 5a6f0c5..e988a33 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.ts +++ b/polygerrit-ui/app/elements/admin/gr-repo-commands/gr-repo-commands.ts
@@ -91,8 +91,8 @@ private readonly restApiService = appContext.restApiService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this._loadRepo(); fireTitleChange(this, 'Repo Commands');
diff --git a/polygerrit-ui/app/elements/admin/gr-repo-list/gr-repo-list.ts b/polygerrit-ui/app/elements/admin/gr-repo-list/gr-repo-list.ts index e5225f0..bcbc756 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo-list/gr-repo-list.ts +++ b/polygerrit-ui/app/elements/admin/gr-repo-list/gr-repo-list.ts
@@ -90,8 +90,8 @@ private readonly restApiService = appContext.restApiService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this._getCreateRepoCapability(); fireTitleChange(this, 'Repos'); this._maybeOpenCreateOverlay(this.params);
diff --git a/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.ts b/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.ts index 572612f..6ba9ad8 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.ts +++ b/polygerrit-ui/app/elements/admin/gr-repo/gr-repo.ts
@@ -141,8 +141,8 @@ private readonly restApiService = appContext.restApiService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this._loadRepo(); fireTitleChange(this, `${this.repo}`);
diff --git a/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.ts b/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.ts index c3b35a9..f8c03d2 100644 --- a/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.ts +++ b/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor.ts
@@ -155,8 +155,8 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); // Check needed for test purposes. if (!this._originalRuleValues && this.rule) { // Observer _handleValueChange is called after the ready()
diff --git a/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor_test.js b/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor_test.js index 9cc6357..9c3646a 100644 --- a/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor_test.js +++ b/polygerrit-ui/app/elements/admin/gr-rule-editor/gr-rule-editor_test.js
@@ -197,7 +197,7 @@ element._setupValues(element.rule); flush(); flush(() => { - element.attached(); + element.connectedCallback(); done(); }); }); @@ -306,7 +306,7 @@ flush(); element.rule.value.added = true; flush(() => { - element.attached(); + element.connectedCallback(); done(); }); }); @@ -371,7 +371,7 @@ element._setupValues(element.rule); flush(); flush(() => { - element.attached(); + element.connectedCallback(); done(); }); }); @@ -425,7 +425,7 @@ flush(); element.rule.value.added = true; flush(() => { - element.attached(); + element.connectedCallback(); done(); }); }); @@ -482,7 +482,7 @@ element._setupValues(element.rule); flush(); flush(() => { - element.attached(); + element.connectedCallback(); done(); }); }); @@ -524,7 +524,7 @@ flush(); element.rule.value.added = true; flush(() => { - element.attached(); + element.connectedCallback(); done(); }); }); @@ -571,7 +571,7 @@ element._setupValues(element.rule); flush(); flush(() => { - element.attached(); + element.connectedCallback(); done(); }); });
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.ts b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.ts index 64e2810..6fbee32 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.ts +++ b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.ts
@@ -125,8 +125,8 @@ reporting: ReportingService = appContext.reportingService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); getPluginLoader() .awaitPluginsLoaded() .then(() => {
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts index 60fcd1f..1b85e21 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts +++ b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts
@@ -118,8 +118,8 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this._loadPreferences(); }
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.ts b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.ts index c9b095c..bcbddb7 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.ts +++ b/polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.ts
@@ -173,8 +173,8 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); getPluginLoader() .awaitPluginsLoaded() .then(() => {
diff --git a/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.ts b/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.ts index d834b16..3b1c61e 100644 --- a/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.ts +++ b/polygerrit-ui/app/elements/change-list/gr-dashboard-view/gr-dashboard-view.ts
@@ -127,8 +127,8 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this._loadPreferences(); this.addEventListener('reload', e => { e.stopPropagation();
diff --git a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts index f555b01..f3962a1 100644 --- a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts +++ b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts
@@ -604,20 +604,6 @@ } /** @override */ - connectedCallback() { - super.connectedCallback(); - this._throttledToggleChangeStar = this._throttleWrap(e => - this._handleToggleChangeStar(e as CustomKeyboardEvent) - ); - } - - /** @override */ - disconnectedCallback() { - this.disconnected$.next(); - super.disconnectedCallback(); - } - - /** @override */ created() { super.created(); @@ -650,8 +636,11 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); + this._throttledToggleChangeStar = this._throttleWrap(e => + this._handleToggleChangeStar(e as CustomKeyboardEvent) + ); this._getServerConfig().then(config => { this._serverConfig = config; this._replyDisabled = false; @@ -718,8 +707,8 @@ } /** @override */ - detached() { - super.detached(); + disconnectedCallback() { + this.disconnected$.next(); this.unlisten(window, 'scroll', '_handleScroll'); this.unlisten(document, 'visibilitychange', '_handleVisibilityChange'); this.cancelDebouncer(DEBOUNCER_REPLY_OVERLAY_REFIT); @@ -728,6 +717,7 @@ if (this._updateCheckTimerHandle) { this._cancelUpdateCheckTimer(); } + super.disconnectedCallback(); } get messagesList(): GrMessagesList | null {
diff --git a/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts b/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts index 076fc7f..d71253d 100644 --- a/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts +++ b/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts
@@ -355,8 +355,8 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); getPluginLoader() .awaitPluginsLoaded() .then(() => { @@ -404,10 +404,10 @@ } /** @override */ - detached() { - super.detached(); + disconnectedCallback() { this._cancelDiffs(); this.cancelDebouncer(DEBOUNCER_LOADING_CHANGE); + super.disconnectedCallback(); } /**
diff --git a/polygerrit-ui/app/elements/change/gr-message/gr-message.ts b/polygerrit-ui/app/elements/change/gr-message/gr-message.ts index d0e9e23..964ab2a 100644 --- a/polygerrit-ui/app/elements/change/gr-message/gr-message.ts +++ b/polygerrit-ui/app/elements/change/gr-message/gr-message.ts
@@ -201,8 +201,8 @@ this.addEventListener('click', e => this._handleClick(e)); } - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this.restApiService.getConfig().then(config => { this.config = config; });
diff --git a/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.ts b/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.ts index 788a42d..1f51138 100644 --- a/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.ts +++ b/polygerrit-ui/app/elements/change/gr-related-changes-list/gr-related-changes-list.ts
@@ -300,8 +300,8 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); // We listen to `new-section-loaded` events to allow plugins to trigger // visibility computations, if their content or visibility changed. this.addEventListener('new-section-loaded', () =>
diff --git a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.ts b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.ts index 1175b1d..b9d943d 100644 --- a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.ts +++ b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.ts
@@ -394,8 +394,8 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); ((IronA11yAnnouncer as unknown) as FixIronA11yAnnouncer).requestAvailability(); this._getAccount().then(account => { if (account) this._account = account; @@ -428,8 +428,9 @@ } /** @override */ - detached() { + disconnectedCallback() { this.cancelDebouncer(DEBOUNCER_STORE); + super.disconnectedCallback(); } open(focusTarget?: FocusTarget) {
diff --git a/polygerrit-ui/app/elements/change/gr-upload-help-dialog/gr-upload-help-dialog.ts b/polygerrit-ui/app/elements/change/gr-upload-help-dialog/gr-upload-help-dialog.ts index d26ae53..161bc2f 100644 --- a/polygerrit-ui/app/elements/change/gr-upload-help-dialog/gr-upload-help-dialog.ts +++ b/polygerrit-ui/app/elements/change/gr-upload-help-dialog/gr-upload-help-dialog.ts
@@ -66,8 +66,8 @@ private readonly restApiService = appContext.restApiService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this.restApiService .getLoggedIn() .then(loggedIn =>
diff --git a/polygerrit-ui/app/elements/core/gr-account-dropdown/gr-account-dropdown.ts b/polygerrit-ui/app/elements/core/gr-account-dropdown/gr-account-dropdown.ts index 33c95db..c0f7320 100644 --- a/polygerrit-ui/app/elements/core/gr-account-dropdown/gr-account-dropdown.ts +++ b/polygerrit-ui/app/elements/core/gr-account-dropdown/gr-account-dropdown.ts
@@ -65,8 +65,8 @@ private readonly restApiService = appContext.restApiService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this._handleLocationChange(); this.listen(window, 'location-change', '_handleLocationChange'); this.restApiService.getConfig().then(cfg => { @@ -82,9 +82,9 @@ } /** @override */ - detached() { - super.detached(); + disconnectedCallback() { this.unlisten(window, 'location-change', '_handleLocationChange'); + super.disconnectedCallback(); } _getLinks(switchAccountUrl: string, path: string) {
diff --git a/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.ts b/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.ts index 4aad50d..9a652df 100644 --- a/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.ts +++ b/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.ts
@@ -117,8 +117,8 @@ private readonly restApiService = appContext.restApiService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this.listen(document, EventType.SERVER_ERROR, '_handleServerError'); this.listen(document, EventType.NETWORK_ERROR, '_handleNetworkError'); this.listen(document, EventType.SHOW_ALERT, '_handleShowAlert'); @@ -138,8 +138,7 @@ } /** @override */ - detached() { - super.detached(); + disconnectedCallback() { this._clearHideAlertHandle(); this.unlisten(document, EventType.SERVER_ERROR, '_handleServerError'); this.unlisten(document, EventType.NETWORK_ERROR, '_handleNetworkError'); @@ -153,6 +152,7 @@ if (this._authErrorHandlerDeregistrationHook) { this._authErrorHandlerDeregistrationHook(); } + super.disconnectedCallback(); } _shouldSuppressError(msg: string) {
diff --git a/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog.ts b/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog.ts index b76f0d3..4f37fad 100644 --- a/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog.ts +++ b/polygerrit-ui/app/elements/core/gr-keyboard-shortcuts-dialog/gr-keyboard-shortcuts-dialog.ts
@@ -75,19 +75,19 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this.addKeyboardShortcutDirectoryListener( this.keyboardShortcutDirectoryListener ); } /** @override */ - detached() { - super.detached(); + disconnectedCallback() { this.removeKeyboardShortcutDirectoryListener( this.keyboardShortcutDirectoryListener ); + super.disconnectedCallback(); } _handleCloseTap(e: MouseEvent) {
diff --git a/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.ts b/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.ts index 847e49f..9c088c2 100644 --- a/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.ts +++ b/polygerrit-ui/app/elements/core/gr-main-header/gr-main-header.ts
@@ -162,15 +162,15 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this._loadAccount(); this._loadConfig(); } /** @override */ - detached() { - super.detached(); + disconnectedCallback() { + super.disconnectedCallback(); } reload() {
diff --git a/polygerrit-ui/app/elements/core/gr-search-bar/gr-search-bar.ts b/polygerrit-ui/app/elements/core/gr-search-bar/gr-search-bar.ts index 942effe..504a9e5 100644 --- a/polygerrit-ui/app/elements/core/gr-search-bar/gr-search-bar.ts +++ b/polygerrit-ui/app/elements/core/gr-search-bar/gr-search-bar.ts
@@ -198,8 +198,8 @@ this.query = (input: string) => this._getSearchSuggestions(input); } - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this.restApiService.getConfig().then((serverConfig?: ServerInfo) => { const mergeability = serverConfig &&
diff --git a/polygerrit-ui/app/elements/core/gr-smart-search/gr-smart-search.ts b/polygerrit-ui/app/elements/core/gr-smart-search/gr-smart-search.ts index c5d6df9..02036b4 100644 --- a/polygerrit-ui/app/elements/core/gr-smart-search/gr-smart-search.ts +++ b/polygerrit-ui/app/elements/core/gr-smart-search/gr-smart-search.ts
@@ -63,8 +63,8 @@ private readonly restApiService = appContext.restApiService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this.restApiService.getConfig().then(cfg => { this._config = cfg; });
diff --git a/polygerrit-ui/app/elements/diff/gr-apply-fix-dialog/gr-apply-fix-dialog.ts b/polygerrit-ui/app/elements/diff/gr-apply-fix-dialog/gr-apply-fix-dialog.ts index 24f34a6..c95f87d 100644 --- a/polygerrit-ui/app/elements/diff/gr-apply-fix-dialog/gr-apply-fix-dialog.ts +++ b/polygerrit-ui/app/elements/diff/gr-apply-fix-dialog/gr-apply-fix-dialog.ts
@@ -131,8 +131,8 @@ }); } - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this.refitOverlay = () => { // re-center the dialog as content changed fireEvent(this.$.applyFixOverlay, 'iron-resize'); @@ -140,11 +140,11 @@ this.addEventListener('diff-context-expanded', this.refitOverlay); } - detached() { - super.detached(); + disconnectedCallback() { if (this.refitOverlay) { this.removeEventListener('diff-context-expanded', this.refitOverlay); } + super.disconnectedCallback(); } _showSelectedFixSuggestion(fixSuggestion: FixSuggestionInfo) {
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-element.ts b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-element.ts index 25aac8d..ae82036 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-element.ts +++ b/polygerrit-ui/app/elements/diff/gr-diff-builder/gr-diff-builder-element.ts
@@ -161,11 +161,11 @@ _cancelableRenderPromise: CancelablePromise<unknown> | null = null; /** @override */ - detached() { - super.detached(); + disconnectedCallback() { if (this._builder) { this._builder.clear(); } + super.disconnectedCallback(); } get diffElement() {
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-cursor/gr-diff-cursor.ts b/polygerrit-ui/app/elements/diff/gr-diff-cursor/gr-diff-cursor.ts index a19968c..35df51a 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-cursor/gr-diff-cursor.ts +++ b/polygerrit-ui/app/elements/diff/gr-diff-cursor/gr-diff-cursor.ts
@@ -128,8 +128,8 @@ /** @override */ disconnectedCallback() { - super.disconnectedCallback(); window.removeEventListener('scroll', this._boundHandleWindowScroll); + super.disconnectedCallback(); } // Don't remove - used by clients embedding gr-diff outside of Gerrit.
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-highlight/gr-diff-highlight.ts b/polygerrit-ui/app/elements/diff/gr-diff-highlight/gr-diff-highlight.ts index 0f53a26..fb28e2b 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-highlight/gr-diff-highlight.ts +++ b/polygerrit-ui/app/elements/diff/gr-diff-highlight/gr-diff-highlight.ts
@@ -88,8 +88,9 @@ } /** @override */ - detached() { + disconnectedCallback() { this.cancelDebouncer(DEBOUNCER_SELECTION_CHANGE); + super.disconnectedCallback(); } get diffBuilder() {
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.ts b/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.ts index e6f08b01..d40a8a6 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.ts +++ b/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host.ts
@@ -307,17 +307,17 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this._getLoggedIn().then(loggedIn => { this._loggedIn = loggedIn; }); } /** @override */ - detached() { - super.detached(); + disconnectedCallback() { this.clear(); + super.disconnectedCallback(); } initLayers() {
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host_test.js b/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host_test.js index 3d6383b..267ca5f 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host_test.js +++ b/polygerrit-ui/app/elements/diff/gr-diff-host/gr-diff-host_test.js
@@ -970,7 +970,7 @@ suite('create-comment', () => { setup(async () => { loggedIn = true; - element.attached(); + element.connectedCallback(); await flush(); });
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-mode-selector/gr-diff-mode-selector.ts b/polygerrit-ui/app/elements/diff/gr-diff-mode-selector/gr-diff-mode-selector.ts index 0a22556..cc7bb98 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-mode-selector/gr-diff-mode-selector.ts +++ b/polygerrit-ui/app/elements/diff/gr-diff-mode-selector/gr-diff-mode-selector.ts
@@ -45,7 +45,9 @@ private readonly restApiService = appContext.restApiService; - attached() { + /** @override */ + connectedCallback() { + super.connectedCallback(); ((IronA11yAnnouncer as unknown) as FixIronA11yAnnouncer).requestAvailability(); }
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-processor/gr-diff-processor.ts b/polygerrit-ui/app/elements/diff/gr-diff-processor/gr-diff-processor.ts index f4772e3..c13092f 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-processor/gr-diff-processor.ts +++ b/polygerrit-ui/app/elements/diff/gr-diff-processor/gr-diff-processor.ts
@@ -114,17 +114,17 @@ _isScrolling?: boolean; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this.listen(window, 'scroll', '_handleWindowScroll'); } /** @override */ - detached() { - super.detached(); + disconnectedCallback() { this.cancelDebouncer(DEBOUNCER_RESET_IS_SCROLLING); this.cancel(); this.unlisten(window, 'scroll', '_handleWindowScroll'); + super.disconnectedCallback(); } _handleWindowScroll() {
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-processor/gr-diff-processor_test.js b/polygerrit-ui/app/elements/diff/gr-diff-processor/gr-diff-processor_test.js index b8f7498..5ecc962 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-processor/gr-diff-processor_test.js +++ b/polygerrit-ui/app/elements/diff/gr-diff-processor/gr-diff-processor_test.js
@@ -1113,7 +1113,7 @@ test('detaching cancels', () => { element = basicFixture.instantiate(); sinon.stub(element, 'cancel'); - element.detached(); + element.disconnectedCallback(); assert(element.cancel.called); }); });
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-selection/gr-diff-selection.ts b/polygerrit-ui/app/elements/diff/gr-diff-selection/gr-diff-selection.ts index 39acb86..cee5ef6 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-selection/gr-diff-selection.ts +++ b/polygerrit-ui/app/elements/diff/gr-diff-selection/gr-diff-selection.ts
@@ -74,8 +74,8 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this.classList.add(SelectionClass.RIGHT); }
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts index d8dbb49..e94cd23 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts +++ b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
@@ -325,11 +325,6 @@ this._throttledToggleFileReviewed = this._throttleWrap(e => this._handleToggleFileReviewed(e as CustomKeyboardEvent) ); - } - - /** @override */ - attached() { - super.attached(); this._getLoggedIn().then(loggedIn => { this._loggedIn = loggedIn; }); @@ -343,10 +338,11 @@ } /** @override */ - detached() { + disconnectedCallback() { if (this._onRenderHandler) { this.$.diffHost.removeEventListener('render', this._onRenderHandler); } + super.disconnectedCallback(); } _getLoggedIn() {
diff --git a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.ts b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.ts index 802397b..2e97765 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.ts +++ b/polygerrit-ui/app/elements/diff/gr-diff/gr-diff.ts
@@ -295,17 +295,17 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this._observeNodes(); } /** @override */ - detached() { + disconnectedCallback() { this.cancelDebouncer(RENDER_DIFF_TABLE_DEBOUNCE_NAME); - super.detached(); this._unobserveIncrementalNodes(); this._unobserveNodes(); + super.disconnectedCallback(); } showNoChangeMessage(
diff --git a/polygerrit-ui/app/elements/documentation/gr-documentation-search/gr-documentation-search.ts b/polygerrit-ui/app/elements/documentation/gr-documentation-search/gr-documentation-search.ts index aff9c3d..580571d 100644 --- a/polygerrit-ui/app/elements/documentation/gr-documentation-search/gr-documentation-search.ts +++ b/polygerrit-ui/app/elements/documentation/gr-documentation-search/gr-documentation-search.ts
@@ -56,8 +56,8 @@ private readonly restApiService = appContext.restApiService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); fireTitleChange(this, 'Documentation Search'); }
diff --git a/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.ts b/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.ts index dd9592d..b273af7 100644 --- a/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.ts +++ b/polygerrit-ui/app/elements/edit/gr-editor-view/gr-editor-view.ts
@@ -140,16 +140,17 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this._getEditPrefs().then(prefs => { this._prefs = prefs; }); } /** @override */ - detached() { + disconnectedCallback() { this.cancelDebouncer(DEBOUNCER_STORE); + super.disconnectedCallback(); } get storageKey() {
diff --git a/polygerrit-ui/app/elements/plugins/gr-endpoint-decorator/gr-endpoint-decorator.ts b/polygerrit-ui/app/elements/plugins/gr-endpoint-decorator/gr-endpoint-decorator.ts index 998e84e..b52fef0 100644 --- a/polygerrit-ui/app/elements/plugins/gr-endpoint-decorator/gr-endpoint-decorator.ts +++ b/polygerrit-ui/app/elements/plugins/gr-endpoint-decorator/gr-endpoint-decorator.ts
@@ -51,12 +51,12 @@ _endpointCallBack: (info: ModuleInfo) => void = () => {}; /** @override */ - detached() { - super.detached(); + disconnectedCallback() { for (const [el, domHook] of this._domHooks) { domHook.handleInstanceDetached(el); } getPluginEndpoints().onDetachedEndpoint(this.name, this._endpointCallBack); + super.disconnectedCallback(); } _initDecoration(
diff --git a/polygerrit-ui/app/elements/plugins/gr-external-style/gr-external-style.ts b/polygerrit-ui/app/elements/plugins/gr-external-style/gr-external-style.ts index b4fd804..25cc354 100644 --- a/polygerrit-ui/app/elements/plugins/gr-external-style/gr-external-style.ts +++ b/polygerrit-ui/app/elements/plugins/gr-external-style/gr-external-style.ts
@@ -64,8 +64,8 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this._importAndApply(); }
diff --git a/polygerrit-ui/app/elements/settings/gr-agreements-list/gr-agreements-list.ts b/polygerrit-ui/app/elements/settings/gr-agreements-list/gr-agreements-list.ts index 8fa2c94..6768497 100644 --- a/polygerrit-ui/app/elements/settings/gr-agreements-list/gr-agreements-list.ts +++ b/polygerrit-ui/app/elements/settings/gr-agreements-list/gr-agreements-list.ts
@@ -37,8 +37,8 @@ private readonly restApiService = appContext.restApiService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this.loadData(); }
diff --git a/polygerrit-ui/app/elements/settings/gr-cla-view/gr-cla-view.ts b/polygerrit-ui/app/elements/settings/gr-cla-view/gr-cla-view.ts index bbfcd7c..2ae1634 100644 --- a/polygerrit-ui/app/elements/settings/gr-cla-view/gr-cla-view.ts +++ b/polygerrit-ui/app/elements/settings/gr-cla-view/gr-cla-view.ts
@@ -68,8 +68,8 @@ private readonly restApiService = appContext.restApiService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this.loadData(); fireTitleChange(this, 'New Contributor Agreement');
diff --git a/polygerrit-ui/app/elements/settings/gr-http-password/gr-http-password.ts b/polygerrit-ui/app/elements/settings/gr-http-password/gr-http-password.ts index 701c098..0842b3a 100644 --- a/polygerrit-ui/app/elements/settings/gr-http-password/gr-http-password.ts +++ b/polygerrit-ui/app/elements/settings/gr-http-password/gr-http-password.ts
@@ -56,8 +56,8 @@ private readonly restApiService = appContext.restApiService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this.loadData(); }
diff --git a/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view.ts b/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view.ts index e6858b4..35448c4 100644 --- a/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view.ts +++ b/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view.ts
@@ -211,8 +211,8 @@ private readonly restApiService = appContext.restApiService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); // Polymer 2: anchor tag won't work on shadow DOM // we need to manually calling scrollIntoView when hash changed this.listen(window, 'location-change', '_handleLocationChange'); @@ -299,9 +299,9 @@ }); } - detached() { - super.detached(); + disconnectedCallback() { this.unlisten(window, 'location-change', '_handleLocationChange'); + super.disconnectedCallback(); } _handleLocationChange() {
diff --git a/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view_test.js b/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view_test.js index 98abb3fb..79789bb 100644 --- a/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view_test.js +++ b/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view_test.js
@@ -329,7 +329,7 @@ test('emails are loaded without emailToken', () => { sinon.stub(element.$.emailEditor, 'loadData'); element.params = {}; - element.attached(); + element.connectedCallback(); assert.isTrue(element.$.emailEditor.loadData.calledOnce); }); @@ -465,7 +465,7 @@ confirmEmailStub = stubRestApi('confirmEmail').returns( new Promise(resolve => { resolveConfirm = resolve; })); element.params = {view: GerritView.SETTINGS, emailToken: 'foo'}; - element.attached(); + element.connectedCallback(); }); test('it is used to confirm email via rest API', () => {
diff --git a/polygerrit-ui/app/elements/shared/gr-alert/gr-alert.ts b/polygerrit-ui/app/elements/shared/gr-alert/gr-alert.ts index 3b584c7..135abfc 100644 --- a/polygerrit-ui/app/elements/shared/gr-alert/gr-alert.ts +++ b/polygerrit-ui/app/elements/shared/gr-alert/gr-alert.ts
@@ -72,21 +72,21 @@ _actionCallback?: () => void; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this._boundTransitionEndHandler = () => this._handleTransitionEnd(); this.addEventListener('transitionend', this._boundTransitionEndHandler); } /** @override */ - detached() { - super.detached(); + disconnectedCallback() { if (this._boundTransitionEndHandler) { this.removeEventListener( 'transitionend', this._boundTransitionEndHandler ); } + super.disconnectedCallback(); } show(text: string, actionText?: string, actionCallback?: () => void) {
diff --git a/polygerrit-ui/app/elements/shared/gr-autocomplete/gr-autocomplete.ts b/polygerrit-ui/app/elements/shared/gr-autocomplete/gr-autocomplete.ts index 6390237..f34c3ad 100644 --- a/polygerrit-ui/app/elements/shared/gr-autocomplete/gr-autocomplete.ts +++ b/polygerrit-ui/app/elements/shared/gr-autocomplete/gr-autocomplete.ts
@@ -209,16 +209,16 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this.listen(document.body, 'click', '_handleBodyClick'); } /** @override */ - detached() { - super.detached(); + disconnectedCallback() { this.unlisten(document.body, 'click', '_handleBodyClick'); this.cancelDebouncer(DEBOUNCER_UPDATE_SUGGESTIONS); + super.disconnectedCallback(); } get focusStart() {
diff --git a/polygerrit-ui/app/elements/shared/gr-avatar/gr-avatar.ts b/polygerrit-ui/app/elements/shared/gr-avatar/gr-avatar.ts index 72b47e0..b628125 100644 --- a/polygerrit-ui/app/elements/shared/gr-avatar/gr-avatar.ts +++ b/polygerrit-ui/app/elements/shared/gr-avatar/gr-avatar.ts
@@ -42,8 +42,8 @@ private readonly restApiService = appContext.restApiService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); Promise.all([ this._getConfig(), getPluginLoader().awaitPluginsLoaded(),
diff --git a/polygerrit-ui/app/elements/shared/gr-comment-thread/gr-comment-thread.ts b/polygerrit-ui/app/elements/shared/gr-comment-thread/gr-comment-thread.ts index a2c2eaa..1673b2e 100644 --- a/polygerrit-ui/app/elements/shared/gr-comment-thread/gr-comment-thread.ts +++ b/polygerrit-ui/app/elements/shared/gr-comment-thread/gr-comment-thread.ts
@@ -230,8 +230,8 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this._getLoggedIn().then(loggedIn => { this._showActions = loggedIn; });
diff --git a/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.ts b/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.ts index c839118..5a84d9c 100644 --- a/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.ts +++ b/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.ts
@@ -281,8 +281,8 @@ reporting = appContext.reportingService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this.restApiService.getAccount().then(account => { this._selfAccount = account; }); @@ -297,14 +297,14 @@ } /** @override */ - detached() { - super.detached(); + disconnectedCallback() { this.cancelDebouncer(DEBOUNCER_FIRE_UPDATE); this.cancelDebouncer(DEBOUNCER_STORE); this.cancelDebouncer(DEBOUNCER_DRAFT_TOAST); if (this.textarea) { this.textarea.closeDropdown(); } + super.disconnectedCallback(); } _getAuthor(comment: UIComment) {
diff --git a/polygerrit-ui/app/elements/shared/gr-cursor-manager/gr-cursor-manager.ts b/polygerrit-ui/app/elements/shared/gr-cursor-manager/gr-cursor-manager.ts index 0d60784..4592b0c 100644 --- a/polygerrit-ui/app/elements/shared/gr-cursor-manager/gr-cursor-manager.ts +++ b/polygerrit-ui/app/elements/shared/gr-cursor-manager/gr-cursor-manager.ts
@@ -113,9 +113,9 @@ } /** @override */ - detached() { - super.detached(); + disconnectedCallback() { this.unsetCursor(); + super.disconnectedCallback(); } /**
diff --git a/polygerrit-ui/app/elements/shared/gr-date-formatter/gr-date-formatter.ts b/polygerrit-ui/app/elements/shared/gr-date-formatter/gr-date-formatter.ts index e1134f9..f53d87f 100644 --- a/polygerrit-ui/app/elements/shared/gr-date-formatter/gr-date-formatter.ts +++ b/polygerrit-ui/app/elements/shared/gr-date-formatter/gr-date-formatter.ts
@@ -133,8 +133,8 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this._loadPreferences(); }
diff --git a/polygerrit-ui/app/elements/shared/gr-download-commands/gr-download-commands.ts b/polygerrit-ui/app/elements/shared/gr-download-commands/gr-download-commands.ts index db343c6..f00d3bb 100644 --- a/polygerrit-ui/app/elements/shared/gr-download-commands/gr-download-commands.ts +++ b/polygerrit-ui/app/elements/shared/gr-download-commands/gr-download-commands.ts
@@ -63,8 +63,8 @@ private readonly restApiService = appContext.restApiService; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this._getLoggedIn().then(loggedIn => { this._loggedIn = loggedIn; });
diff --git a/polygerrit-ui/app/elements/shared/gr-editable-content/gr-editable-content.ts b/polygerrit-ui/app/elements/shared/gr-editable-content/gr-editable-content.ts index 1ecf3d5..c849fac 100644 --- a/polygerrit-ui/app/elements/shared/gr-editable-content/gr-editable-content.ts +++ b/polygerrit-ui/app/elements/shared/gr-editable-content/gr-editable-content.ts
@@ -128,8 +128,9 @@ } /** @override */ - detached() { + disconnectedCallback() { this.cancelDebouncer(DEBOUNCER_STORE); + super.disconnectedCallback(); } _contentChanged() {
diff --git a/polygerrit-ui/app/elements/shared/gr-hovercard-account/gr-hovercard-account.ts b/polygerrit-ui/app/elements/shared/gr-hovercard-account/gr-hovercard-account.ts index 9a2f966..9cbd11c 100644 --- a/polygerrit-ui/app/elements/shared/gr-hovercard-account/gr-hovercard-account.ts +++ b/polygerrit-ui/app/elements/shared/gr-hovercard-account/gr-hovercard-account.ts
@@ -95,8 +95,8 @@ this.reporting = appContext.reportingService; } - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); this.restApiService.getConfig().then(config => { this._config = config; });
diff --git a/polygerrit-ui/app/elements/shared/gr-hovercard/gr-hovercard-behavior.ts b/polygerrit-ui/app/elements/shared/gr-hovercard/gr-hovercard-behavior.ts index b8f0161..74c47d20 100644 --- a/polygerrit-ui/app/elements/shared/gr-hovercard/gr-hovercard-behavior.ts +++ b/polygerrit-ui/app/elements/shared/gr-hovercard/gr-hovercard-behavior.ts
@@ -119,8 +119,8 @@ private isScheduledToHide?: boolean; /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); if (!this._target) { this._target = this.target; } @@ -141,11 +141,11 @@ this.listen(this, 'mouseleave', 'unlock'); } - detached() { - super.detached(); + disconnectedCallback() { this.cancelShowDebouncer(); this.cancelHideDebouncer(); this.unlock(); + super.disconnectedCallback(); } /** @override */
diff --git a/polygerrit-ui/app/elements/shared/gr-list-view/gr-list-view.ts b/polygerrit-ui/app/elements/shared/gr-list-view/gr-list-view.ts index f364c01..71b8bc7 100644 --- a/polygerrit-ui/app/elements/shared/gr-list-view/gr-list-view.ts +++ b/polygerrit-ui/app/elements/shared/gr-list-view/gr-list-view.ts
@@ -64,9 +64,9 @@ path?: string; /** @override */ - detached() { - super.detached(); + disconnectedCallback() { this.cancelDebouncer(DEBOUNCER_RELOAD); + super.disconnectedCallback(); } _filterChanged(newFilter?: string, oldFilter?: string) {
diff --git a/polygerrit-ui/app/elements/shared/gr-page-nav/gr-page-nav.ts b/polygerrit-ui/app/elements/shared/gr-page-nav/gr-page-nav.ts index 57f38df..623e6a3 100644 --- a/polygerrit-ui/app/elements/shared/gr-page-nav/gr-page-nav.ts +++ b/polygerrit-ui/app/elements/shared/gr-page-nav/gr-page-nav.ts
@@ -48,14 +48,14 @@ this.bodyScrollHandler = () => this._handleBodyScroll(); } - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); window.addEventListener('scroll', this.bodyScrollHandler); } - detached() { - super.detached(); + disconnectedCallback() { window.removeEventListener('scroll', this.bodyScrollHandler); + super.disconnectedCallback(); } _handleBodyScroll() {
diff --git a/polygerrit-ui/app/elements/shared/gr-repo-branch-picker/gr-repo-branch-picker.ts b/polygerrit-ui/app/elements/shared/gr-repo-branch-picker/gr-repo-branch-picker.ts index c49427a..9dee18f 100644 --- a/polygerrit-ui/app/elements/shared/gr-repo-branch-picker/gr-repo-branch-picker.ts +++ b/polygerrit-ui/app/elements/shared/gr-repo-branch-picker/gr-repo-branch-picker.ts
@@ -72,8 +72,8 @@ } /** @override */ - attached() { - super.attached(); + connectedCallback() { + super.connectedCallback(); if (this.repo) { this.$.repoInput.setText(this.repo); }
diff --git a/polygerrit-ui/app/mixins/gr-tooltip-mixin/gr-tooltip-mixin.ts b/polygerrit-ui/app/mixins/gr-tooltip-mixin/gr-tooltip-mixin.ts index 75ad608..e60c614 100644 --- a/polygerrit-ui/app/mixins/gr-tooltip-mixin/gr-tooltip-mixin.ts +++ b/polygerrit-ui/app/mixins/gr-tooltip-mixin/gr-tooltip-mixin.ts
@@ -88,7 +88,6 @@ /** @override */ disconnectedCallback() { - super.disconnectedCallback(); // NOTE: if you define your own `detached` in your component // then this won't take affect (as its not a class yet) this._handleHideTooltip(); @@ -96,6 +95,7 @@ this.removeEventListener('mouseenter', this.mouseenterHandler); } window.removeEventListener('scroll', this.windowScrollHandler); + super.disconnectedCallback(); } @observe('hasTooltip')
diff --git a/polygerrit-ui/app/mixins/keyboard-shortcut-mixin/keyboard-shortcut-mixin.ts b/polygerrit-ui/app/mixins/keyboard-shortcut-mixin/keyboard-shortcut-mixin.ts index ab85b87..85931b4 100644 --- a/polygerrit-ui/app/mixins/keyboard-shortcut-mixin/keyboard-shortcut-mixin.ts +++ b/polygerrit-ui/app/mixins/keyboard-shortcut-mixin/keyboard-shortcut-mixin.ts
@@ -960,10 +960,10 @@ /** @override */ disconnectedCallback() { - super.disconnectedCallback(); if (shortcutManager.detachHost(this)) { this.removeOwnKeyBindings(); } + super.disconnectedCallback(); } keyboardShortcuts() {