commit 5cece3a4983ab1f470a88df9552fb0b7a40da587
author Alex Spradlin <alexaspradlin@google.com> Tue Feb 23 10:40:11 2021 -0800
committer Alex Spradlin <alexaspradlin@google.com> Tue Feb 23 10:50:39 2021 -0800
tree 209f21d7643e0c451989dcc87682f017eb3677d5
parent 76eb96fe56a8489912a06c82c0066bfda757ae6d

Add parameterless constructors to REST API classes

Add protected constructors with no parameters to any REST API class
reachable from ChangeInfo. Remove the final keyword when needed.

A new REST API endpoint diffs two ChangeInfo instances using
reflection and must construct classes reachable from ChangeInfo.
However, only parameterless constructors can be used.

Signed-off-by: Alex Spradlin <alexaspradlin@google.com>
Change-Id: I2b47c082c051e1a8c3fe4d2d018e9db52e9daec3

java/com/google/gerrit/extensions/common/ActionInfo.java

diff --git a/java/com/google/gerrit/extensions/common/ActionInfo.java b/java/com/google/gerrit/extensions/common/ActionInfo.java
index 8039949..2144ed5 100644
--- a/java/com/google/gerrit/extensions/common/ActionInfo.java
+++ b/java/com/google/gerrit/extensions/common/ActionInfo.java
@@ -73,4 +73,6 @@
   public int hashCode() {
     return Objects.hash(method, label, title, enabled);
   }
+
+  protected ActionInfo() {}
 }

java/com/google/gerrit/extensions/common/AttentionSetInfo.java

diff --git a/java/com/google/gerrit/extensions/common/AttentionSetInfo.java b/java/com/google/gerrit/extensions/common/AttentionSetInfo.java
index 490d394..ba865fb 100644
--- a/java/com/google/gerrit/extensions/common/AttentionSetInfo.java
+++ b/java/com/google/gerrit/extensions/common/AttentionSetInfo.java
@@ -53,4 +53,6 @@
   public int hashCode() {
     return Objects.hash(account, lastUpdate, reason);
   }
+
+  protected AttentionSetInfo() {}
 }

java/com/google/gerrit/extensions/common/FetchInfo.java

diff --git a/java/com/google/gerrit/extensions/common/FetchInfo.java b/java/com/google/gerrit/extensions/common/FetchInfo.java
index 472dba2..4b1e941 100644
--- a/java/com/google/gerrit/extensions/common/FetchInfo.java
+++ b/java/com/google/gerrit/extensions/common/FetchInfo.java
@@ -42,4 +42,6 @@
   public int hashCode() {
     return Objects.hash(url, ref, commands);
   }
+
+  protected FetchInfo() {}
 }

java/com/google/gerrit/extensions/common/SubmitRequirementInfo.java

diff --git a/java/com/google/gerrit/extensions/common/SubmitRequirementInfo.java b/java/com/google/gerrit/extensions/common/SubmitRequirementInfo.java
index 3483de5..a13e645 100644
--- a/java/com/google/gerrit/extensions/common/SubmitRequirementInfo.java
+++ b/java/com/google/gerrit/extensions/common/SubmitRequirementInfo.java
@@ -18,9 +18,9 @@
 import java.util.Objects;
 
 public class SubmitRequirementInfo {
-  public final String status;
-  public final String fallbackText;
-  public final String type;
+  public String status;
+  public String fallbackText;
+  public String type;
 
   public SubmitRequirementInfo(String status, String fallbackText, String type) {
     this.status = status;
@@ -55,4 +55,6 @@
         .add("type", type)
         .toString();
   }
+
+  protected SubmitRequirementInfo() {}
 }

java/com/google/gerrit/extensions/common/TrackingIdInfo.java

diff --git a/java/com/google/gerrit/extensions/common/TrackingIdInfo.java b/java/com/google/gerrit/extensions/common/TrackingIdInfo.java
index d9b8e22..3d35e08 100644
--- a/java/com/google/gerrit/extensions/common/TrackingIdInfo.java
+++ b/java/com/google/gerrit/extensions/common/TrackingIdInfo.java
@@ -38,4 +38,6 @@
   public int hashCode() {
     return Objects.hash(system, id);
   }
+
+  protected TrackingIdInfo() {}
 }

java/com/google/gerrit/extensions/common/WebLinkInfo.java

diff --git a/java/com/google/gerrit/extensions/common/WebLinkInfo.java b/java/com/google/gerrit/extensions/common/WebLinkInfo.java
index 84fd970..ba12be0 100644
--- a/java/com/google/gerrit/extensions/common/WebLinkInfo.java
+++ b/java/com/google/gerrit/extensions/common/WebLinkInfo.java
@@ -64,4 +64,6 @@
         + target
         + "}";
   }
+
+  protected WebLinkInfo() {}
 }