commit 5be2b9a58d45ee7824824beeaa1a2c2c0811399b
author Ben Rohlfs <brohlfs@google.com> Tue Aug 06 21:08:03 2019 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue Aug 06 21:08:03 2019 +0000
tree 5b975bf9aed236a99f366283d9c7864054c7bb88
parent 44b3a7c43304deab225a694982e6a4b0f5c966b6
parent d72cfec7ae29765d234e3eb5a985cc47a6a8e6f8

Merge "Fix missing input box when create a comment"

polygerrit-ui/app/elements/shared/gr-comment/gr-comment.js

diff --git a/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.js b/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.js
index 23dd080..57835a3 100644
--- a/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.js
+++ b/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.js
@@ -319,6 +319,11 @@
     },
 
     _editingChanged(editing, previousValue) {
+      // Polymer 2: observer fires when at least one property is defined.
+      // Do nothing to prevent comment.__editing being overwritten
+      // if previousValue is undefined
+      if (previousValue === undefined) return;
+
       this.$.container.classList.toggle('editing', editing);
       if (this.comment && this.comment.id) {
         this.$$('.cancel').hidden = !editing;