commit 543b7f172e7f9f159a5c65b7deffd0fb5d811d06
author Youssef Elghareeb <ghareeb@google.com> Wed Feb 08 11:08:47 2023 +0100
committer Youssef Elghareeb <ghareeb@google.com> Wed Feb 08 11:32:14 2023 +0100
tree 247a8517224a15f666e8d62baf15e43b9011c8b9
parent 96e9b91081f4f709d8f8df9bc4f23e21145bfed1

Log a warning if the SR evaluator fails to evaluate an expression

This can help us understand why the evaluation failed.

Release-Notes: skip
Google-Bug-Id: b/268022374
Change-Id: Iaa491a007e0ac540ff69daedf72d8221ce788c90

java/com/google/gerrit/server/project/SubmitRequirementsEvaluatorImpl.java

diff --git a/java/com/google/gerrit/server/project/SubmitRequirementsEvaluatorImpl.java b/java/com/google/gerrit/server/project/SubmitRequirementsEvaluatorImpl.java
index f60e9e5..870fc3e 100644
--- a/java/com/google/gerrit/server/project/SubmitRequirementsEvaluatorImpl.java
+++ b/java/com/google/gerrit/server/project/SubmitRequirementsEvaluatorImpl.java
@@ -155,6 +155,8 @@
       PredicateResult predicateResult = evaluatePredicateTree(predicate, changeData);
       return SubmitRequirementExpressionResult.create(expression, predicateResult);
     } catch (QueryParseException | SubmitRequirementEvaluationException e) {
+      logger.atWarning().withCause(e).log(
+          "Failed to evaluate submit requirement expression: %s", expression.expressionString());
       return SubmitRequirementExpressionResult.error(expression, e.getMessage());
     }
   }