Add @types/sinon to plugins package.json Since the bzlmod/rules_js migration, plugin web tests fail to type-check with TS7016: rules_js links only direct dependencies of plugins/package.json into the Bazel node_modules tree, so the transitive @types/sinon (via @open-wc/testing) that yarn's flat layout used to hoist is no longer visible to tsc. Declare @types/sinon directly, mirroring polygerrit-ui/package.json, and refresh both lockfiles. Release-Notes: skip Change-Id: I6f7c914202391697ec878d5a54164c7c07c8dd11
diff --git a/plugins/package.json b/plugins/package.json index efd7a90..9e4737b 100644 --- a/plugins/package.json +++ b/plugins/package.json
@@ -34,6 +34,7 @@ "@gerritcodereview/typescript-api": "3.14.0", "@material/web": "^2.4.1", "@open-wc/testing": "^4.0.0", + "@types/sinon": "^17.0.4", "@web/dev-server-esbuild": "^1.0.4", "@web/test-runner": "^0.20.2", "lit": "^3.3.1",
diff --git a/plugins/pnpm-lock.yaml b/plugins/pnpm-lock.yaml index a2aca79..1c99c8c 100644 --- a/plugins/pnpm-lock.yaml +++ b/plugins/pnpm-lock.yaml
@@ -101,6 +101,9 @@ '@open-wc/testing': specifier: ^4.0.0 version: 4.0.0 + '@types/sinon': + specifier: ^17.0.4 + version: 17.0.4 '@web/dev-server-esbuild': specifier: ^1.0.4 version: 1.0.4
diff --git a/plugins/yarn.lock b/plugins/yarn.lock index 551be7b..26b3007 100644 --- a/plugins/yarn.lock +++ b/plugins/yarn.lock
@@ -491,10 +491,10 @@ dependencies: "@types/chai" "^4.2.12" -"@gerritcodereview/typescript-api@3.13.0": - version "3.13.0" - resolved "https://registry.yarnpkg.com/@gerritcodereview/typescript-api/-/typescript-api-3.13.0.tgz#c7f5ac20f8b5b575424508eb1deb260a290ca0f1" - integrity sha512-1TvqARSNO9SXnnCzJKZVz9SFTr4hx1ZzBR0jyRZM6Xd4lLw3YwCfXozD9E8Pm4pfBWmN9WDkURboEG85p7ICag== +"@gerritcodereview/typescript-api@3.14.0": + version "3.14.0" + resolved "https://registry.yarnpkg.com/@gerritcodereview/typescript-api/-/typescript-api-3.14.0.tgz#0ba1a06b68593e84e5a7525baf91521fdbcb2920" + integrity sha512-GhYzh6h/bHUz2cU1pzHwlfWDeGSkGAlBulfvrUyG4N3tuA/jqUp5LSBDeeJHzXgmOSdNE7Qyravjh3wDd0REyg== "@hapi/bourne@^3.0.0": version "3.0.0" @@ -1170,7 +1170,7 @@ "@types/chai" "*" "@types/sinon" "*" -"@types/sinon@*": +"@types/sinon@*", "@types/sinon@^17.0.4": version "17.0.4" resolved "https://registry.yarnpkg.com/@types/sinon/-/sinon-17.0.4.tgz#fd9a3e8e07eea1a3f4a6f82a972c899e5778f369" integrity sha512-RHnIrhfPO3+tJT0s7cFaXGZvsL4bbR3/k7z3P312qMS4JaS2Tk+KiwiLx1S0rQ56ERj00u1/BtdyVd0FY+Pdew==