Google Git
Sign in
gerrit / gerrit / 48ff71492703f04cd636682022b83ceb56cd88a7
commit48ff71492703f04cd636682022b83ceb56cd88a7[log] [tgz]
authorGal Paikin <paiking@google.com>Mon Oct 18 17:23:45 2021 +0200
committerGal Paikin <paiking@google.com>Tue Oct 19 13:17:07 2021 +0200
treec94f369d283badc5fc3ae1fff40e53c502be9e0e
parent0980d3303642a75491fe340674a294b8142ecfc0 [diff]
Fix bug about persisting copied votes on submit

This bug is happening because when submitting a change, on some submit
strategies, we create a new patch-set which causes us to persist copied
votes. When persisting copied votes with ListOfFilesUnchanged copy
condition, we need to fetch the commit. This fails for non-existent
patch-sets (we are just now creating it).

Instead of fixing the above, we do the following:

We ensure we don't call this code at all for patch-sets created during
submit. This is unnecessary since during submit we anyway store
approvals (and they don't need to be "copied approvals"). It's best to
make sure we don't copy approvals twice, even though that bug never
surfaced (luck).

Change-Id: Ibc61b390814ec12ed2bdd1b8dd199187c14cbea4
5 files changed
tree: c94f369d283badc5fc3ae1fff40e53c502be9e0e
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. WORKSPACE
  41. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.