tree c94f369d283badc5fc3ae1fff40e53c502be9e0e
parent 0980d3303642a75491fe340674a294b8142ecfc0
author Gal Paikin <paiking@google.com> 1634570625 +0200
committer Gal Paikin <paiking@google.com> 1634642227 +0200

Fix bug about persisting copied votes on submit

This bug is happening because when submitting a change, on some submit
strategies, we create a new patch-set which causes us to persist copied
votes. When persisting copied votes with ListOfFilesUnchanged copy
condition, we need to fetch the commit. This fails for non-existent
patch-sets (we are just now creating it).

Instead of fixing the above, we do the following:

We ensure we don't call this code at all for patch-sets created during
submit. This is unnecessary since during submit we anyway store
approvals (and they don't need to be "copied approvals"). It's best to
make sure we don't copy approvals twice, even though that bug never
surfaced (luck).

Change-Id: Ibc61b390814ec12ed2bdd1b8dd199187c14cbea4