commit 46c041fc9075f9aed0d5834455f8489d066f22a3
author Dave Borowitz <dborowitz@google.com> Thu Jun 07 13:12:37 2018 -0400
committer Dave Borowitz <dborowitz@google.com> Fri Sep 14 14:02:18 2018 -0700
tree 742f0c338f57b2c809a0b783d9b10bff808571b7
parent d3a779a8b4d6477e91bcb046e47292a945b581cd

Don't serve gwtjsonrpc endpoints if GWT UI isn't enabled

The old-style RPC endpoints are not a public interface and practically
speaking can't really be used except by GWT code; there's no point in
serving them if there is no GWT UI.

Change-Id: I5abe6ca48448d6eca3f47dbaf681c1553e637203

java/com/google/gerrit/httpd/WebModule.java

diff --git a/java/com/google/gerrit/httpd/WebModule.java b/java/com/google/gerrit/httpd/WebModule.java
index 538d605..d115f43 100644
--- a/java/com/google/gerrit/httpd/WebModule.java
+++ b/java/com/google/gerrit/httpd/WebModule.java
@@ -56,7 +56,9 @@
     installAuthModule();
     if (options.enableMasterFeatures()) {
       install(new UrlModule(options, authConfig));
-      install(new UiRpcModule());
+      if (options.enableGwtUi()) {
+        install(new UiRpcModule());
+      }
     }
     install(new GerritRequestModule());
     install(new GitOverHttpServlet.Module(options.enableMasterFeatures()));