commit 46163a82f8d2efb69c3bb54bab6c2f904dadad44
author Edwin Kempin <ekempin@google.com> Mon Aug 12 07:19:18 2019 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Mon Aug 12 07:19:18 2019 +0000
tree 4cdf70431a24feec593a7885d060742f8590a197
parent 0a927f24461cb49fe34d97dd273f0dd392046305
parent 3ba12d90de6081c1f8f6829fa6a0324c0881e387

Merge "SubmitRuleEvaluator: Simply logging of errors"

java/com/google/gerrit/server/project/SubmitRuleEvaluator.java

diff --git a/java/com/google/gerrit/server/project/SubmitRuleEvaluator.java b/java/com/google/gerrit/server/project/SubmitRuleEvaluator.java
index 1b1869c..5879430 100644
--- a/java/com/google/gerrit/server/project/SubmitRuleEvaluator.java
+++ b/java/com/google/gerrit/server/project/SubmitRuleEvaluator.java
@@ -119,11 +119,7 @@
 
   private List<SubmitRecord> ruleError(String err, Exception e) {
     if (opts.logErrors()) {
-      if (e == null) {
-        logger.atSevere().log(err);
-      } else {
-        logger.atSevere().withCause(e).log(err);
-      }
+      logger.atSevere().withCause(e).log(err);
       return defaultRuleError();
     }
     return createRuleError(err);