commit 42be51720ad7cbe8f6f8f29b74b74525dfa5b340
author Patrick Hiesel <hiesel@google.com> Mon Jan 15 17:32:25 2018 +0100
committer Patrick Hiesel <hiesel@google.com> Tue Jan 16 09:03:55 2018 +0000
tree 31e6e8f7258c36d86b9427bb9fcebad6d043a08e
parent 1cfd4d17728bd6b8d6d6af644caa64f9792cbee8

Remove project state check from ChangeControl#addPatchSet

All callers are already explicitly checking for the project state so
there is no need to perform the check implicitly once more.

Change-Id: I956eddb1647778454293a47bfee5459952783b17

java/com/google/gerrit/server/project/ChangeControl.java

diff --git a/java/com/google/gerrit/server/project/ChangeControl.java b/java/com/google/gerrit/server/project/ChangeControl.java
index 8cd12f8..10c04af 100644
--- a/java/com/google/gerrit/server/project/ChangeControl.java
+++ b/java/com/google/gerrit/server/project/ChangeControl.java
@@ -176,9 +176,7 @@
 
   /** Can this user add a patch set to this change? */
   private boolean canAddPatchSet(ReviewDb db) throws OrmException {
-    if (!(refControl.asForRef().testOrFalse(RefPermission.CREATE_CHANGE)
-            && getProjectControl().getProjectState().statePermitsWrite())
-        || isPatchSetLocked(db)) {
+    if (!(refControl.asForRef().testOrFalse(RefPermission.CREATE_CHANGE)) || isPatchSetLocked(db)) {
       return false;
     }
     if (isOwner()) {