| commit | 429687d2ad47bc7093a45b6c62b8f29275a1eb48 | [log] [tgz] |
|---|---|---|
| author | David Pursehouse <dpursehouse@collab.net> | Thu Sep 06 17:38:13 2018 +0900 |
| committer | David Pursehouse <dpursehouse@collab.net> | Thu Sep 06 17:38:13 2018 +0900 |
| tree | c03b109c08ce9daf5a9ce6d1f40ed5f23eb32f43 | |
| parent | 8cf9a823ea8ef741792372d0862eac1ae018929e [diff] |
ListMailFilter: Fix operator precedence warning raised by ErrorProne Add grouping parenthesis to make the operator precedence explicit. See http://errorprone.info/bugpattern/OperatorPrecedence Change-Id: Ica10d3e1494e9109883ef0c327015e423e91dd31
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/ListMailFilter.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/ListMailFilter.java index 21347cb..2e7c828 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/ListMailFilter.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/ListMailFilter.java
@@ -54,7 +54,8 @@ } boolean match = mailPattern.matcher(message.from().email).find(); - if (mode == ListFilterMode.WHITELIST && !match || mode == ListFilterMode.BLACKLIST && match) { + if ((mode == ListFilterMode.WHITELIST && !match) + || (mode == ListFilterMode.BLACKLIST && match)) { log.info("Mail message from " + message.from() + " rejected by list filter"); return false; }