SubmitRuleEvaluator: Simply logging of errors
No caller ever passes null as exception into the ruleError(String,
Exception) method. In addition Flogger's withCause(Exception) method can
handles null inputs. Hence there is no need to differentiate between the
exception being null and the exception being non-null.
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I2fdca6d00c76a5abac4e0316a3187d76f4eee820
diff --git a/java/com/google/gerrit/server/project/SubmitRuleEvaluator.java b/java/com/google/gerrit/server/project/SubmitRuleEvaluator.java
index 1b1869c..5879430 100644
--- a/java/com/google/gerrit/server/project/SubmitRuleEvaluator.java
+++ b/java/com/google/gerrit/server/project/SubmitRuleEvaluator.java
@@ -119,11 +119,7 @@
private List<SubmitRecord> ruleError(String err, Exception e) {
if (opts.logErrors()) {
- if (e == null) {
- logger.atSevere().log(err);
- } else {
- logger.atSevere().withCause(e).log(err);
- }
+ logger.atSevere().withCause(e).log(err);
return defaultRuleError();
}
return createRuleError(err);
