commit 3b5cbacd15e4dca16aeba99a9858ade1d9a1a2d0
author Ben Rohlfs <brohlfs@google.com> Wed Jan 18 09:44:18 2023 +0100
committer Ben Rohlfs <brohlfs@google.com> Wed Jan 18 09:44:18 2023 +0100
tree 8af368834f198cacf104b2ed1f9fe3f71ffe32cc
parent 30902a965e2f85956820f5c2c40afa0300663312

Fix files dropdown on diff page

Hooray for better event typing.

Release-Notes: skip
Google-Bug-Id: b/265828320
Change-Id: If50af873ce49e6348b143aaec2cd939aca3d71a8

polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts

diff --git a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
index a9cbcbd..e9da5b6 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
@@ -1454,10 +1454,10 @@
   }
 
   // Private but used in tests.
-  handleFileChange(e: CustomEvent) {
-    const path = e.detail.value;
+  handleFileChange(e: ValueChangedEvent<string>) {
+    const path: string = e.detail.value;
     if (path === this.path) return;
-    this.getChangeModel().navigateToDiff(path);
+    this.getChangeModel().navigateToDiff({path});
   }
 
   // Private but used in tests.

polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view_test.ts

diff --git a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view_test.ts b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view_test.ts
index 1999a82..9bbe4b3 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view_test.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view_test.ts
@@ -1842,6 +1842,7 @@
         new CustomEvent('value-change', {detail: {value: 'file2'}})
       );
       assert.isTrue(navToDiffStub.calledOnce);
+      assert.deepEqual(navToDiffStub.lastCall.firstArg, {path: 'file2'});
 
       // This is to mock the param change triggered by above navigate
       viewModel.setState({