Revert "Use router to set url instead of href" This reverts commit 8a8f02c927fd221a4dc02e6d3adf9b0e06b64309. Reason for revert: We prefer normal links and are fixing the issue with the full page reload in a different way: For button clicks we will only handle direct clicks on its element, not its children. `stopPropagation` for `<a>` was causing issue, because then the top-level page.js click handler would not pick up the click. It normally intercepts `<a>` clicks and thus prevents full page reloads Release-Notes: skip Change-Id: I4061868a0bd3a3d270a5a095c97a9bff7c840b9f
diff --git a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts index c0ed3b3..6c1b681 100644 --- a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts +++ b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.ts
@@ -1256,7 +1256,14 @@ flatten down-arrow class="showCopyLinkDialogButton" - @click=${() => this.copyLinksDropdown?.toggleDropdown()} + @click=${(e: MouseEvent) => { + // We don't want to handle clicks on the star or the <a> link. + // Calling `stopPropagation()` from the click handler of <a> is not an + // option, because then the click does not reach the top-level page.js + // click handler and would result is a full page reload. + if ((e.target as HTMLElement)?.nodeName !== 'GR-BUTTON') return; + this.copyLinksDropdown?.toggleDropdown(); + }} ><gr-change-star id="changeStar" .change=${this.change} @@ -1267,10 +1274,7 @@ <a class="changeNumber" aria-label=${`Change ${this.change?._number}`} - @click=${(e: MouseEvent) => { - fireReload(this, true); - e.stopPropagation(); - }} + href=${ifDefined(this.computeChangeUrl(true))} >${this.change?._number}</a > </gr-button>