commit 39a658f6600a5d27ac30ef472ab961ce0d2e8ee3
author Paladox none <thomasmulhall410@yahoo.com> Mon Jul 29 19:39:50 2019 +0000
committer Paladox none <thomasmulhall410@yahoo.com> Mon Aug 05 13:27:26 2019 +0000
tree 044cff2991f1d1675976067271f5cc5064657b83
parent 469be5e280c2edc9a3570bf5e4e69c811b4cf0da

Add undefined check to gr-access-section

Change-Id: Ia657a116d81bcf36451779e53f70517e7825bd1b

polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.js

diff --git a/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.js b/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.js
index d771448..9841e67 100644
--- a/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.js
+++ b/polygerrit-ui/app/elements/admin/gr-access-section/gr-access-section.js
@@ -123,6 +123,9 @@
 
     _computePermissions(name, capabilities, labels) {
       let allPermissions;
+      if (!this.section || !this.section.value) {
+        return [];
+      }
       if (name === GLOBAL_NAME) {
         allPermissions = this.toSortedArray(capabilities);
       } else {
@@ -147,6 +150,7 @@
 
     _computeLabelOptions(labels) {
       const labelOptions = [];
+      if (!labels) { return []; }
       for (const labelName of Object.keys(labels)) {
         labelOptions.push({
           id: 'label-' + labelName,
@@ -226,7 +230,7 @@
     },
 
     _isEditEnabled(canUpload, ownerOf, sectionId) {
-      return canUpload || ownerOf.indexOf(sectionId) >= 0;
+      return canUpload || (ownerOf && ownerOf.indexOf(sectionId) >= 0);
     },
 
     _computeSectionClass(editing, canUpload, ownerOf, editingRef, deleted) {