| commit | 387a01d699ed2c98c4e8f22cba464f4d03083918 | [log] [tgz] |
|---|---|---|
| author | Mark Bekhet <mark.bekhet@ericsson.com> | Tue Apr 06 15:01:42 2021 -0400 |
| committer | David Ostrovsky <david@ostrovsky.org> | Fri May 14 08:13:56 2021 +0200 |
| tree | f256246d558b70a88848d586b63f15ca120f50c4 | |
| parent | df853d3e1e73db2f3f19562c0fe066b058bf2616 [diff] |
Adapt SendMessage of the NoShell command to AsyncCommand type Before this change, the SendMessage class inside the NoShell command implemented the Command interface. Therefore, the command was using instances of OutputStream and closing them at the end of the command. Given that the channel isn't closed at this stage, this produced a problem as apache-sshd calls the flush method of one of the output streams. Therefore, the command was hanging and didn't release the terminal until the user pressed a key. This change adapts the SendMessage class to an AyncCommand type. Therefore, the Apache library treats the command as AsyncCommand and uses the newly introduced I/O streams instead of normal streams. As a result, the problematic flush call of the output stream doesn't happen, because the normal output stream is not initialized, instead the I/O streams are initialized and used. An integration test is added to verify that the command doesn't hang indefinitely. It does so by setting a timeout to the command. Bug: Issue 11142 Change-Id: Ia6ed0d4ee264d2e901eaa17ea444bf715e3b44db
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.