tree f256246d558b70a88848d586b63f15ca120f50c4
parent df853d3e1e73db2f3f19562c0fe066b058bf2616
author Mark Bekhet <mark.bekhet@ericsson.com> 1617735702 -0400
committer David Ostrovsky <david@ostrovsky.org> 1620972836 +0200

Adapt SendMessage of the NoShell command to AsyncCommand type

Before this change, the SendMessage class inside the NoShell command
implemented the Command interface. Therefore, the command was using
instances of OutputStream and closing them at the end of the command.
Given that the channel isn't closed at this stage, this produced a
problem as apache-sshd calls the flush method of one of the output
streams. Therefore, the command was hanging and didn't release the
terminal until the user pressed a key.

This change adapts the SendMessage class to an AyncCommand type.
Therefore, the Apache library treats the command as AsyncCommand and
uses the newly introduced I/O streams instead of normal streams. As a
result, the problematic flush call of the output stream doesn't happen,
because the normal output stream is not initialized, instead the I/O
streams are initialized and used.

An integration test is added to verify that the command doesn't hang
indefinitely. It does so by setting a timeout to the command.

Bug: Issue 11142
Change-Id: Ia6ed0d4ee264d2e901eaa17ea444bf715e3b44db