commit | 435706e55f38a9021bd6cef29f95a11dbd804acd | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Mon Aug 01 11:47:11 2022 +0200 |
committer | Edwin Kempin <ekempin@google.com> | Fri Aug 05 10:49:21 2022 +0200 |
tree | fa8b04fd928bf8fda0d0f773202e39f5548a885a | |
parent | 2dcc26032799728335ad3bbf0c7fc4ecb375ad3e [diff] |
PostReview: Fix email for removing an email without Gerrit account as CC If reviewer.enableByEmail in project.config is true, it's possible to CC an email for which no Gerrit account exists. Removing this CC via the PostReview REST endpoint (click on the pencil icon next to the CC, remove the CC in the Reply dialog and click SEND) triggered an email that said: <user> removed null from this change. When removing the CC via a DELETE reviewer request (click on Remove CC in the user popup), the triggered email was correct (also see change I4895bca04): <user> removed <email> from this change. Deleting a reviewer via PostReview sends the email via NewChangeSender. NewChangeSender#getRemovedReviewerNames() set address.name() as the reviewer name, which returned null since the reviewer doesn't have a name. Changing this to address.toString(), same as in DeleteReviewerSender#getReviewerNames() fixed this. DeleteReviewerSender is used when a reviewer is deleted via DeleteReviewer where the email is correct. Signed-off-by: Edwin Kempin <ekempin@google.com> Release-Notes: skip Bug: Google b/240670892 Change-Id: I00baa40bc1e5f0e47c911b6211c57168982a8959
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.