tree fa8b04fd928bf8fda0d0f773202e39f5548a885a
parent 2dcc26032799728335ad3bbf0c7fc4ecb375ad3e
author Edwin Kempin <ekempin@google.com> 1659347231 +0200
committer Edwin Kempin <ekempin@google.com> 1659689361 +0200

PostReview: Fix email for removing an email without Gerrit account as CC

If reviewer.enableByEmail in project.config is true, it's possible to CC
an email for which no Gerrit account exists. Removing this CC via the
PostReview REST endpoint (click on the pencil icon next to the CC,
remove the CC in the Reply dialog and click SEND) triggered an email
that said:

  <user> removed null from this change.

When removing the CC via a DELETE reviewer request (click on Remove CC
in the user popup), the triggered email was correct (also see change
I4895bca04):

  <user> removed <email> from this change.

Deleting a reviewer via PostReview sends the email via NewChangeSender.
NewChangeSender#getRemovedReviewerNames() set address.name() as the
reviewer name, which returned null since the reviewer doesn't have a
name. Changing this to address.toString(), same as in
DeleteReviewerSender#getReviewerNames() fixed this. DeleteReviewerSender
is used when a reviewer is deleted via DeleteReviewer where the email is
correct.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Release-Notes: skip
Bug: Google b/240670892
Change-Id: I00baa40bc1e5f0e47c911b6211c57168982a8959