WorkQueue: Do not busy-reschedule canceled or done one-shot tasks

Change a4c7a7384ef made Task.run() reschedule the task whenever its
runningState is already set, so that a periodic task that preempts
its own previous run is not dropped. The reschedule delay is
nanosPeriod / 3, which is 0 for one-shot tasks, and the branch also
applies to tasks that will never run again:

* cancel() sets runningState to RUNNING for a CancelableRunnable
  that has not started, to let it clean up.
* A finished one-shot task has runningState DONE.

If a pool thread dequeues such a task just before it is canceled or
after it completed, run() reschedules it with no delay, the next run
reschedules it again, and so on. The task has already been removed
from the queue's task list, so show-queue does not show it, but the
pool thread spins at 100% CPU indefinitely. In production we observed
dozens of replication threads, whose PushOne tasks are canceled when
pruned, each burning a full core in this loop.

Only reschedule periodic tasks that are not canceled or done. A
canceled or completed one-shot task has nothing left to do.

Release-Notes: Fix WorkQueue threads spinning at full CPU after a task was canceled
Change-Id: I3cc878fedc730643739a58853153b7a49b7d5733
2 files changed
tree: bee783817054ed0780f59fd4ea84724f18769a64
  1. .agents/
  2. .aspect/
  3. .gemini/
  4. .github/
  5. .settings/
  6. .ts-out/
  7. antlr3/
  8. configs/
  9. contrib/
  10. Documentation/
  11. e2e-tests/
  12. java/
  13. javatests/
  14. lib/
  15. modules/
  16. plugins/
  17. polygerrit-ui/
  18. prolog/
  19. prologtests/
  20. proto/
  21. resources/
  22. tools/
  23. webapp/
  24. .bazelignore
  25. .bazelproject
  26. .bazelrc
  27. .bazelversion
  28. .editorconfig
  29. .git-blame-ignore-revs
  30. .gitignore
  31. .gitmodules
  32. .gitreview
  33. .mailmap
  34. .nvmrc
  35. .pydevproject
  36. .zuul.yaml
  37. AGENTS.md
  38. BUILD
  39. COPYING
  40. external_deps.lock.json
  41. INSTALL
  42. Jenkinsfile
  43. MODULE.bazel
  44. MODULE.bazel.lock
  45. package.json
  46. pnpm-lock.yaml
  47. pnpm-workspace.yaml
  48. README.md
  49. SUBMITTING_PATCHES
  50. web-dev-server.config.mjs
  51. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on GitHub.

Reporting bugs

Please report bugs on the issue tracker.

Due to spam abuse, membership in the repo-discuss Google Group is required in order to create issues. See the announcement for more info.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Due to spam abuse, membership in the repo-discuss Google Group is required in order to create Gerrit changes on the gerrit-review Gerrit server.

Note that we do not accept Pull Requests via the GitHub mirror.

Getting in contact

Find a full list of contact options on the website.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.