WorkQueue: Do not busy-reschedule canceled or done one-shot tasks Change a4c7a7384ef made Task.run() reschedule the task whenever its runningState is already set, so that a periodic task that preempts its own previous run is not dropped. The reschedule delay is nanosPeriod / 3, which is 0 for one-shot tasks, and the branch also applies to tasks that will never run again: * cancel() sets runningState to RUNNING for a CancelableRunnable that has not started, to let it clean up. * A finished one-shot task has runningState DONE. If a pool thread dequeues such a task just before it is canceled or after it completed, run() reschedules it with no delay, the next run reschedules it again, and so on. The task has already been removed from the queue's task list, so show-queue does not show it, but the pool thread spins at 100% CPU indefinitely. In production we observed dozens of replication threads, whose PushOne tasks are canceled when pruned, each burning a full core in this loop. Only reschedule periodic tasks that are not canceled or done. A canceled or completed one-shot task has nothing left to do. Release-Notes: Fix WorkQueue threads spinning at full CPU after a task was canceled Change-Id: I3cc878fedc730643739a58853153b7a49b7d5733
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on GitHub.
Please report bugs on the issue tracker.
Due to spam abuse, membership in the repo-discuss Google Group is required in order to create issues. See the announcement for more info.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Due to spam abuse, membership in the repo-discuss Google Group is required in order to create Gerrit changes on the gerrit-review Gerrit server.
Note that we do not accept Pull Requests via the GitHub mirror.
Find a full list of contact options on the website.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.