commit 1d9d88552fb46380bda8fcf75cb5193568630e57
author Ben Rohlfs <brohlfs@google.com> Wed Nov 25 20:30:34 2020 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Wed Nov 25 20:30:34 2020 +0000
tree 1b330bf96213181d039112b6aa033ec7e926fd80
parent b95241e85aec575562335ba726c073e9aaaad589
parent 2c9faecb300e1191ff5316e5df74da4f9f6cda7a

Merge "A11y - improve announcing"

polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.ts

diff --git a/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.ts b/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.ts
index 4f3d7ce6..e4e4056 100644
--- a/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.ts
+++ b/polygerrit-ui/app/elements/core/gr-error-manager/gr-error-manager.ts
@@ -336,7 +336,7 @@
     const el = this._createToastAlert();
     el.show(text, actionText, actionCallback);
     this._alertElement = el;
-    this.fire('iron-announce', {text}, {bubbles: true});
+    this.fire('iron-announce', {text: `Alert: ${text}`}, {bubbles: true});
     this.reporting.reportInteraction('show-alert', {text});
   }
 

polygerrit-ui/app/elements/gr-app-element.ts

diff --git a/polygerrit-ui/app/elements/gr-app-element.ts b/polygerrit-ui/app/elements/gr-app-element.ts
index 2915acd..617034b 100644
--- a/polygerrit-ui/app/elements/gr-app-element.ts
+++ b/polygerrit-ui/app/elements/gr-app-element.ts
@@ -492,6 +492,9 @@
         registrationOverlay.refit();
       });
     }
+    // To fix bug announce read after each new view, we reset announce with
+    // empty space
+    this.fire('iron-announce', {text: ' '}, {bubbles: true});
   }
 
   _handleShortcutTriggered(event: ShortcutTriggeredEvent) {