commit | 196dc7234e17fe78d05a93453935f80705df932f | [log] [tgz] |
---|---|---|
author | Ben Rohlfs <brohlfs@google.com> | Tue Dec 20 18:01:33 2022 +0100 |
committer | Ben Rohlfs <brohlfs@google.com> | Tue Jan 10 12:53:11 2023 +0100 |
tree | 7253a0aa8bd0d249066230160789d99abe7672a2 | |
parent | 2f6b972820262a98ec0bebc102bab1a737b8646c [diff] |
Move handling of COMMENT route from diff view to router The diff view handling the COMMENT router leads to a lot of special casing. Translating the comment ID to a proper diff URL is rather the responsibility of the router. Let's move it there. Apart from just moving there is one small behavior change: We do not show a toast about the chosen patchsets when initially navigating to a diff. That seemed to be unnecessary complexity that is not really beneficial for the user. If the comment was made on ps 5 and we are showing ps5-vs-latest, then there is no reason to call this out. The patch range picker shows that information and the user is expecting it. This change is also important for moving code from diff view into the change model. For example we want to allow the diff view to just observe the patch range in the change model instead of maintaining its own `patchRange` property. This is done in a later change. Release-Notes: skip Google-Bug-Id: b/247042673 Change-Id: I66988bd2b2517b53dc8060ed920e67dfa2ea0d5d
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.