tree 7253a0aa8bd0d249066230160789d99abe7672a2
parent 2f6b972820262a98ec0bebc102bab1a737b8646c
author Ben Rohlfs <brohlfs@google.com> 1671555693 +0100
committer Ben Rohlfs <brohlfs@google.com> 1673351591 +0100

Move handling of COMMENT route from diff view to router

The diff view handling the COMMENT router leads to a lot of special
casing. Translating the comment ID to a proper diff URL is rather the
responsibility of the router. Let's move it there.

Apart from just moving there is one small behavior change: We do not
show a toast about the chosen patchsets when initially navigating to
a diff. That seemed to be unnecessary complexity that is not really
beneficial for the user. If the comment was made on ps 5 and we are
showing ps5-vs-latest, then there is no reason to call this out. The
patch range picker shows that information and the user is expecting
it.

This change is also important for moving code from diff view into the
change model. For example we want to allow the diff view to just
observe the patch range in the change model instead of maintaining its
own `patchRange` property. This is done in a later change.

Release-Notes: skip
Google-Bug-Id: b/247042673
Change-Id: I66988bd2b2517b53dc8060ed920e67dfa2ea0d5d