commit | 18aece335420ff562d551de3aecd4d5a4f514b40 | [log] [tgz] |
---|---|---|
author | Dhruv <dhruvsri@google.com> | Fri May 13 10:35:53 2022 +0200 |
committer | Paladox none <thomasmulhall410@yahoo.com> | Fri May 13 12:47:46 2022 +0000 |
tree | 1f96c01439d7c32c2a1f0a15251b4666a7a3bb59 | |
parent | 309272bffd71f1f09089e95cb2e9d654d39fcec2 [diff] |
Remove reload message from dark theme toggle Replace with firing a toast instead. Release-Notes: skip Change-Id: I6c05f49ed78424ab144f65432cb8c00eae7bc255 (cherry picked from commit 2b4fc746b19198e04bc45d0fa02d5eba0f2ff24e)
diff --git a/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view.ts b/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view.ts index bf0ca98..94c21f6 100644 --- a/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view.ts +++ b/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view.ts
@@ -376,9 +376,7 @@ @change=${this.handleToggleDark} @click=${this.onTapDarkToggle} ></paper-toggle-button> - <div id="darkThemeToggleLabel"> - Dark theme (the toggle reloads the page) - </div> + <div id="darkThemeToggleLabel">Dark theme</div> </div> </section> <h2 @@ -1103,6 +1101,7 @@ // private but used in test reloadPage() { + fireAlert(this, 'Reloading...'); windowLocationReload(); }
diff --git a/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view_test.ts b/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view_test.ts index 58ea901..6a8f575 100644 --- a/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view_test.ts +++ b/polygerrit-ui/app/elements/settings/gr-settings-view/gr-settings-view_test.ts
@@ -177,7 +177,7 @@ > </paper-toggle-button> <div id="darkThemeToggleLabel"> - Dark theme (the toggle reloads the page) + Dark theme </div> </div> </section>