| <!DOCTYPE html> |
| <!-- |
| @license |
| Copyright (C) 2018 The Android Open Source Project |
| |
| Licensed under the Apache License, Version 2.0 (the "License"); |
| you may not use this file except in compliance with the License. |
| You may obtain a copy of the License at |
| |
| http://www.apache.org/licenses/LICENSE-2.0 |
| |
| Unless required by applicable law or agreed to in writing, software |
| distributed under the License is distributed on an "AS IS" BASIS, |
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| See the License for the specific language governing permissions and |
| limitations under the License. |
| --> |
| |
| <meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes"> |
| <meta charset="utf-8"> |
| <title>gr-thread-list</title> |
| |
| <script src="/node_modules/@webcomponents/webcomponentsjs/custom-elements-es5-adapter.js"></script> |
| |
| <script src="/node_modules/@webcomponents/webcomponentsjs/webcomponents-lite.js"></script> |
| <script src="/components/wct-browser-legacy/browser.js"></script> |
| |
| <test-fixture id="basic"> |
| <template> |
| <gr-thread-list></gr-thread-list> |
| </template> |
| </test-fixture> |
| |
| <script type="module"> |
| import '../../../test/common-test-setup.js'; |
| import './gr-thread-list.js'; |
| import {dom} from '@polymer/polymer/lib/legacy/polymer.dom.js'; |
| import {NO_THREADS_MSG} from '../../../constants/messages.js'; |
| suite('gr-thread-list tests', () => { |
| let element; |
| let sandbox; |
| let threadElements; |
| |
| function getVisibleThreads() { |
| return [...dom(element.root) |
| .querySelectorAll('gr-comment-thread')] |
| .filter(e => e.style.display !== 'none'); |
| } |
| |
| setup(done => { |
| sandbox = sinon.sandbox.create(); |
| element = fixture('basic'); |
| element.threads = [ |
| { |
| comments: [ |
| { |
| __path: '/COMMIT_MSG', |
| author: { |
| _account_id: 1000000, |
| name: 'user', |
| username: 'user', |
| }, |
| patch_set: 4, |
| id: 'ecf0b9fa_fe1a5f62', |
| line: 5, |
| updated: '2018-02-08 18:49:18.000000000', |
| message: 'test', |
| unresolved: true, |
| }, |
| { |
| id: '503008e2_0ab203ee', |
| path: '/COMMIT_MSG', |
| line: 5, |
| in_reply_to: 'ecf0b9fa_fe1a5f62', |
| updated: '2018-02-13 22:48:48.018000000', |
| message: 'draft', |
| unresolved: true, |
| __draft: true, |
| __draftID: '0.m683trwff68', |
| __editing: false, |
| patch_set: '2', |
| }, |
| ], |
| patchNum: 4, |
| path: '/COMMIT_MSG', |
| line: 5, |
| rootId: 'ecf0b9fa_fe1a5f62', |
| start_datetime: '2018-02-08 18:49:18.000000000', |
| }, |
| { |
| comments: [ |
| { |
| __path: 'test.txt', |
| author: { |
| _account_id: 1000000, |
| name: 'user', |
| username: 'user', |
| }, |
| patch_set: 3, |
| id: '09a9fb0a_1484e6cf', |
| side: 'PARENT', |
| updated: '2018-02-13 22:47:19.000000000', |
| message: 'Some comment on another patchset.', |
| unresolved: false, |
| }, |
| ], |
| patchNum: 3, |
| path: 'test.txt', |
| rootId: '09a9fb0a_1484e6cf', |
| start_datetime: '2018-02-13 22:47:19.000000000', |
| commentSide: 'PARENT', |
| }, |
| { |
| comments: [ |
| { |
| __path: '/COMMIT_MSG', |
| author: { |
| _account_id: 1000000, |
| name: 'user', |
| username: 'user', |
| }, |
| patch_set: 2, |
| id: '8caddf38_44770ec1', |
| updated: '2018-02-13 22:48:40.000000000', |
| message: 'Another unresolved comment', |
| unresolved: true, |
| }, |
| ], |
| patchNum: 2, |
| path: '/COMMIT_MSG', |
| rootId: '8caddf38_44770ec1', |
| start_datetime: '2018-02-13 22:48:40.000000000', |
| }, |
| { |
| comments: [ |
| { |
| __path: '/COMMIT_MSG', |
| author: { |
| _account_id: 1000000, |
| name: 'user', |
| username: 'user', |
| }, |
| patch_set: 2, |
| id: 'scaddf38_44770ec1', |
| line: 4, |
| updated: '2018-02-14 22:48:40.000000000', |
| message: 'Yet another unresolved comment', |
| unresolved: true, |
| }, |
| ], |
| patchNum: 2, |
| path: '/COMMIT_MSG', |
| line: 4, |
| rootId: 'scaddf38_44770ec1', |
| start_datetime: '2018-02-14 22:48:40.000000000', |
| }, |
| { |
| comments: [ |
| { |
| id: 'zcf0b9fa_fe1a5f62', |
| path: '/COMMIT_MSG', |
| line: 6, |
| updated: '2018-02-15 22:48:48.018000000', |
| message: 'resolved draft', |
| unresolved: false, |
| __draft: true, |
| __draftID: '0.m683trwff68', |
| __editing: false, |
| patch_set: '2', |
| }, |
| ], |
| patchNum: 4, |
| path: '/COMMIT_MSG', |
| line: 6, |
| rootId: 'zcf0b9fa_fe1a5f62', |
| start_datetime: '2018-02-09 18:49:18.000000000', |
| }, |
| { |
| comments: [ |
| { |
| __path: '/COMMIT_MSG', |
| author: { |
| _account_id: 1000000, |
| name: 'user', |
| username: 'user', |
| }, |
| patch_set: 4, |
| id: 'rc1', |
| line: 5, |
| updated: '2019-02-08 18:49:18.000000000', |
| message: 'test', |
| unresolved: true, |
| robot_id: 'rc1', |
| }, |
| ], |
| patchNum: 4, |
| path: '/COMMIT_MSG', |
| line: 5, |
| rootId: 'rc1', |
| start_datetime: '2019-02-08 18:49:18.000000000', |
| }, |
| { |
| comments: [ |
| { |
| __path: '/COMMIT_MSG', |
| author: { |
| _account_id: 1000000, |
| name: 'user', |
| username: 'user', |
| }, |
| patch_set: 4, |
| id: 'rc2', |
| line: 7, |
| updated: '2019-03-08 18:49:18.000000000', |
| message: 'test', |
| unresolved: true, |
| robot_id: 'rc2', |
| }, |
| { |
| __path: '/COMMIT_MSG', |
| author: { |
| _account_id: 1000000, |
| name: 'user', |
| username: 'user', |
| }, |
| patch_set: 4, |
| id: 'c2_1', |
| line: 5, |
| updated: '2019-03-08 18:49:18.000000000', |
| message: 'test', |
| unresolved: true, |
| }, |
| ], |
| patchNum: 4, |
| path: '/COMMIT_MSG', |
| line: 7, |
| rootId: 'rc2', |
| start_datetime: '2019-03-08 18:49:18.000000000', |
| }, |
| ]; |
| |
| // use flush to render all (bypass initial-count set on dom-repeat) |
| flush(() => { |
| threadElements = dom(element.root) |
| .querySelectorAll('gr-comment-thread'); |
| done(); |
| }); |
| }); |
| |
| teardown(() => { |
| sandbox.restore(); |
| }); |
| |
| test('draft toggle only appears when logged in', () => { |
| assert.equal(getComputedStyle(element.shadowRoot |
| .querySelector('.draftToggle')).display, |
| 'none'); |
| element.loggedIn = true; |
| assert.notEqual(getComputedStyle(element.shadowRoot |
| .querySelector('.draftToggle')).display, |
| 'none'); |
| }); |
| |
| test('show all threads by default', () => { |
| assert.equal(dom(element.root) |
| .querySelectorAll('gr-comment-thread').length, element.threads.length); |
| assert.equal(getVisibleThreads().length, element.threads.length); |
| }); |
| |
| test('onlyShowRobotCommentsWithHumanReply ', () => { |
| element.onlyShowRobotCommentsWithHumanReply = true; |
| flushAsynchronousOperations(); |
| assert.equal( |
| getVisibleThreads().length, |
| element.threads.length - 1); |
| assert.isNotOk(getVisibleThreads().find(th => th.rootId === 'rc1')); |
| }); |
| |
| test('_computeSortedThreads', () => { |
| assert.equal(element._sortedThreads.length, 7); |
| // Draft and unresolved for commit-msg at line 5 |
| assert.equal(element._sortedThreads[0].rootId, |
| 'ecf0b9fa_fe1a5f62'); |
| // unresolved no draft and file level |
| assert.equal(element._sortedThreads[1].rootId, |
| '8caddf38_44770ec1'); |
| // unresolved no draft at line 4 |
| assert.equal(element._sortedThreads[2].rootId, |
| 'scaddf38_44770ec1'); |
| // unresolved no draft at line 5 |
| assert.equal(element._sortedThreads[3].rootId, |
| 'rc1'); |
| // Unresolved no draft at line 7 |
| assert.equal(element._sortedThreads[4].rootId, |
| 'rc2'); |
| // resolved and draft on COMMIT_MSG |
| assert.equal(element._sortedThreads[5].rootId, |
| 'zcf0b9fa_fe1a5f62'); |
| // resolved and on file test.txt |
| assert.equal(element._sortedThreads[6].rootId, |
| '09a9fb0a_1484e6cf'); |
| }); |
| |
| test('thread removal and sort again', () => { |
| threadElements[1].dispatchEvent( |
| new CustomEvent('thread-discard', { |
| detail: {rootId: 'rc2'}, |
| composed: true, bubbles: true, |
| })); |
| flushAsynchronousOperations(); |
| assert.equal(element._sortedThreads.length, 6); |
| assert.equal(element._sortedThreads[0].rootId, |
| 'ecf0b9fa_fe1a5f62'); |
| // unresolved no draft and file level |
| assert.equal(element._sortedThreads[1].rootId, |
| '8caddf38_44770ec1'); |
| // unresolved no draft at line 4 |
| assert.equal(element._sortedThreads[2].rootId, |
| 'scaddf38_44770ec1'); |
| // unresolved no draft at line 5 |
| assert.equal(element._sortedThreads[3].rootId, |
| 'rc1'); |
| // resolved and draft |
| assert.equal(element._sortedThreads[4].rootId, |
| 'zcf0b9fa_fe1a5f62'); |
| // resolved and on file test.txt |
| assert.equal(element._sortedThreads[5].rootId, |
| '09a9fb0a_1484e6cf'); |
| }); |
| |
| test('modification on thread shold not trigger sort again', () => { |
| const currentSortedThreads = [...element._sortedThreads]; |
| for (const thread of currentSortedThreads) { |
| thread.comments = [...thread.comments]; |
| } |
| const modifiedThreads = [...element.threads]; |
| modifiedThreads[5] = {...modifiedThreads[5]}; |
| modifiedThreads[5].comments = [...modifiedThreads[5].comments, { |
| ...modifiedThreads[5].comments[0], |
| unresolved: false, |
| }]; |
| element.threads = modifiedThreads; |
| assert.notDeepEqual(currentSortedThreads, element._sortedThreads); |
| |
| // exact same order as in _computeSortedThreads |
| assert.equal(element._sortedThreads.length, 7); |
| // Draft and unresolved for commit-msg at line 5 |
| assert.equal(element._sortedThreads[0].rootId, |
| 'ecf0b9fa_fe1a5f62'); |
| // unresolved no draft and file level |
| assert.equal(element._sortedThreads[1].rootId, |
| '8caddf38_44770ec1'); |
| // unresolved no draft at line 4 |
| assert.equal(element._sortedThreads[2].rootId, |
| 'scaddf38_44770ec1'); |
| // unresolved no draft at line 5 |
| assert.equal(element._sortedThreads[3].rootId, |
| 'rc1'); |
| // Unresolved no draft at line 7 |
| assert.equal(element._sortedThreads[4].rootId, |
| 'rc2'); |
| // resolved and draft on COMMIT_MSG |
| assert.equal(element._sortedThreads[5].rootId, |
| 'zcf0b9fa_fe1a5f62'); |
| // resolved and on file test.txt |
| assert.equal(element._sortedThreads[6].rootId, |
| '09a9fb0a_1484e6cf'); |
| }); |
| |
| test('non-equal length of sortThreads and threads' + |
| ' shold trigger sort again', () => { |
| const modifiedThreads = [...element.threads]; |
| const currentSortedThreads = [...element._sortedThreads]; |
| element._sortedThreads = []; |
| element.threads = modifiedThreads; |
| assert.deepEqual(currentSortedThreads, element._sortedThreads); |
| |
| // exact same order as in _computeSortedThreads |
| assert.equal(element._sortedThreads.length, 7); |
| // Draft and unresolved for commit-msg at line 5 |
| assert.equal(element._sortedThreads[0].rootId, |
| 'ecf0b9fa_fe1a5f62'); |
| // /COMMIT_MSG |
| // unresolved no draft and file level |
| assert.equal(element._sortedThreads[1].rootId, |
| '8caddf38_44770ec1'); |
| // unresolved no draft at line 4 |
| assert.equal(element._sortedThreads[2].rootId, |
| 'scaddf38_44770ec1'); |
| // unresolved no draft at line 5 |
| assert.equal(element._sortedThreads[3].rootId, |
| 'rc1'); |
| // Unresolved no draft at line 7 |
| assert.equal(element._sortedThreads[4].rootId, |
| 'rc2'); |
| // resolved and draft on COMMIT_MSG |
| assert.equal(element._sortedThreads[5].rootId, |
| 'zcf0b9fa_fe1a5f62'); |
| // resolved and on file test.txt |
| assert.equal(element._sortedThreads[6].rootId, |
| '09a9fb0a_1484e6cf'); |
| }); |
| |
| test('toggle unresolved only shows unresolved comments', () => { |
| MockInteractions.tap(element.shadowRoot.querySelector( |
| '#unresolvedToggle')); |
| flushAsynchronousOperations(); |
| assert.equal(getVisibleThreads().length, 5); |
| }); |
| |
| test('toggle drafts only shows threads with draft comments', () => { |
| MockInteractions.tap(element.shadowRoot.querySelector('#draftToggle')); |
| flushAsynchronousOperations(); |
| assert.equal(getVisibleThreads().length, 2); |
| }); |
| |
| test('toggle drafts and unresolved should ignore comments in editing', () => { |
| const modifiedThreads = [...element.threads]; |
| modifiedThreads[5] = {...modifiedThreads[5]}; |
| modifiedThreads[5].comments = [...modifiedThreads[5].comments]; |
| modifiedThreads[5].comments.push({ |
| ...modifiedThreads[5].comments[0], |
| __editing: true, |
| }); |
| element.threads = modifiedThreads; |
| MockInteractions.tap(element.shadowRoot.querySelector('#draftToggle')); |
| MockInteractions.tap(element.shadowRoot.querySelector( |
| '#unresolvedToggle')); |
| flushAsynchronousOperations(); |
| assert.equal(getVisibleThreads().length, 2); |
| }); |
| |
| test('toggle drafts and unresolved only shows threads with drafts and ' + |
| 'publicly unresolved ', () => { |
| MockInteractions.tap(element.shadowRoot.querySelector('#draftToggle')); |
| MockInteractions.tap(element.shadowRoot.querySelector( |
| '#unresolvedToggle')); |
| flushAsynchronousOperations(); |
| assert.equal(getVisibleThreads().length, 1); |
| }); |
| |
| test('modification events are consumed and displatched', () => { |
| sandbox.spy(element, '_handleCommentsChanged'); |
| const dispatchSpy = sandbox.stub(); |
| element.addEventListener('thread-list-modified', dispatchSpy); |
| threadElements[0].dispatchEvent( |
| new CustomEvent('thread-changed', { |
| detail: { |
| rootId: 'ecf0b9fa_fe1a5f62', path: '/COMMIT_MSG'}, |
| composed: true, bubbles: true, |
| })); |
| assert.isTrue(element._handleCommentsChanged.called); |
| assert.isTrue(dispatchSpy.called); |
| assert.equal(dispatchSpy.lastCall.args[0].detail.rootId, |
| 'ecf0b9fa_fe1a5f62'); |
| assert.equal(dispatchSpy.lastCall.args[0].detail.path, '/COMMIT_MSG'); |
| }); |
| |
| suite('hideToggleButtons', () => { |
| setup(done => { |
| element.hideToggleButtons = true; |
| flush(() => { |
| done(); |
| }); |
| }); |
| |
| test('toggle buttons are hidden', () => { |
| assert.equal(element.shadowRoot.querySelector('.header').style.display, |
| 'none'); |
| }); |
| }); |
| |
| suite('empty thread', () => { |
| setup(done => { |
| element.threads = []; |
| flush(() => { |
| done(); |
| }); |
| }); |
| |
| test('default empty message should show', () => { |
| assert.equal( |
| element.shadowRoot.querySelector('#threads').textContent.trim(), |
| NO_THREADS_MSG |
| ); |
| }); |
| |
| test('can override empty message', () => { |
| element.emptyThreadMsg = 'test'; |
| assert.equal( |
| element.shadowRoot.querySelector('#threads').textContent.trim(), |
| 'test' |
| ); |
| }); |
| }); |
| }); |
| </script> |
